Repository navigation
Conversation
A Session opened for PROPAGATION_NEVER or PROPAGATION_SUPPORTS without a real transaction kept a pooled connection while suspended. Open that Session without a Spring-supplied connection, and disconnect only Hibernate-managed connections. Fixes spring-projectsgh-37706 Signed-off-by: iyuan7 <mryuanvip@163.com>
iyuan7
force-pushed
the
release-suspended-session-connection
branch
from
November 19, 2026 06:55
afdf769 to
09037a8
Compare
Contributor
|
As per my explanation in #37706 (comment), we do not intend to optimize for such SUPPORTS->REQUIRED style nesting but rather for actual transaction nesting. Note that the orginal issue had not been triaged. Please refrain from opening PRs before we had a chance to triage the issue. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
Sessionopened bySpringSessionContextforPROPAGATION_NEVER, or forPROPAGATION_SUPPORTSwithout an existing transaction, was given a connection fromDataSourceUtils. That connection stayed borrowed while the scope was suspended, so a nestedPROPAGATION_REQUIREDtransaction needed a second pooled connection.The non-transactional
Sessionis now opened without a Spring-supplied connection, and Hibernate releases it on suspend. A connection supplied for a real transaction is left alone:manualDisconnect()drops it without returning it to the pool, and resume does not reconnect.Fixes gh-37706
Test plan
NEVERandSUPPORTSborrow at most one connection across the nested transactionSessioncan query again after the nested transaction commitsSUPPORTSinside an existing transaction still uses that transaction's connection