Repository navigation
Conversation
Signed-off-by: Hyunwoo Jung <hyunwoojung@kakao.com>
JsonFileItemWriter when appendingJsonFileItemWriter append mode
JsonFileItemWriter append modeJsonFileItemWriter when appending
noojung
marked this pull request as draft
October 20, 2026 15:17
noojung
marked this pull request as ready for review
October 20, 2026 15:46
Contributor
|
Good catch! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
JsonFileItemWriterproduces invalid JSON in append mode in two cases.Empty chunk: if only empty chunks are written to a file that already contains items (for example, when the processor filters out every item), a trailing comma is left before the closing
]:Restart: if a step is restarted after at least one chunk was committed, two separators are written before the first item after the restart:
The empty-chunk case occurs because
doWrite()writes a separator for existing items without checking whether the chunk is empty. On restart, bothhasExistingItemsand the restoredlinesWrittencause a separator to be written.This PR skips empty chunks and writes a single separator when either condition applies. Regression tests cover both cases.
Related PR