Repository navigation
Support JdbcTemplate injection in JdbcPagingItemReader - #5611
Open
nippyclouding wants to merge 1 commit into
Open
nippyclouding wants to merge 1 commit into
nippyclouding wants to merge 1 commit into
Conversation
Closes spring-projects#5485 Signed-off-by: Lee Sang Won <nippyclouding@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #5485
Add a
JdbcPagingItemReader(JdbcTemplate, PagingQueryProvider)constructor so paging queries can use a supplied template, including an AOP proxy. The query provider is initialized with the template'sDataSource. The existingDataSourceconstructor continues to create its own template.The reader applies its page size as the template's maximum row count and overrides the fetch size only when explicitly configured. Other template settings are preserved. Tests read multiple pages through a class-based AOP proxy with no parameters, positional parameters, and named parameters, and check template configuration and constructor validation.
Validation:
./mvnw -B -ntp -pl spring-batch-infrastructure '-Dtest=JdbcPagingItemReader*Tests' test(46 tests, 4 already disabled)./mvnw -B -ntp package