Repository navigation
Make non-writable file test independent of user privileges - #5609
Open
nippyclouding wants to merge 1 commit into
Open
nippyclouding wants to merge 1 commit into
nippyclouding wants to merge 1 commit into
Conversation
Mock an existing non-writable file instead of relying on filesystem permissions, which root can bypass. Closes spring-projectsgh-3892 Signed-off-by: Lee Sang Won <nippyclouding@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
testOpenWithNonWritableFilemarks a real file read-only and assumesFile.canWrite()returns false. This fails when the JVM runs as root, which can still write to the file.Use a mocked existing, non-writable file and resource so the test continues to verify that opening the writer rejects the file, independently of filesystem permissions. This also removes the fixed
target/no-such-file.foofixture.Closes #3892
Validation on Temurin JDK 25:
./mvnw -B -ntp -pl spring-batch-infrastructure -Dtest=FlatFileItemWriterTests test: 32 tests passed as a regular user on macOS.Should be readonly filefailure. Ran the modified test class in the same environment: all 32 tests passed, with no skips../mvnw -B -ntp package