Repository navigation
Instrument pollable consumers with Spring Integration metrics - #3330
Merged
Merged
Conversation
olegz
force-pushed
the
gh-3328-pollable-metrics
branch
from
November 4, 2026 15:47
dec4954 to
65d56bd
Compare
Make DefaultPollableMessageSource an IntegrationManagement component so it receives a MetricsCaptor / ObservationRegistry. poll() now records spring.integration.receive for received messages and spring.integration.send (or an IntegrationObservation.HANDLER observation) around the handler invocation. Register the pollable bean under its concrete type so the IntegrationManagementConfigurer can discover it. Resolves #3328 Signed-off-by: Oleg Zhurakousky <oleg.zhurakousky@broadcom.com>
olegz
force-pushed
the
gh-3328-pollable-metrics
branch
from
November 4, 2026 15:49
65d56bd to
2918a1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #3328
DefaultPollableMessageSource.poll()invoked the handler directly and was not anIntegrationManagementcomponent, so nospring.integration.*meters/observations were recorded for pollable bindings.DefaultPollableMessageSourcenow implementsIntegrationManagementandBeanNameAware.spring.integration.receive{type=source}per received message andspring.integration.send{type=handler,result,exception}around the handler (per retry attempt), or anIntegrationObservation.HANDLERobservation when anObservationRegistryis active.BindableFunctionProxyFactoryregisters the pollable bean under its concrete type soIntegrationManagementConfigurerdiscovers it.core/spring-cloud-streamtests pass.Not addressed: distinguishing the terminal outcome after retries are exhausted (open question in the issue).