Skip to content

test: modernize exception assertion in MessageConverterTests and fix typo #3323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
siddiqueirshad wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −10
Open

test: modernize exception assertion in MessageConverterTests and fix typo #3323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...-tests/src/test/java/org/springframework/cloud/stream/binder/tck/ContentTypeTckTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -742,7 +742,7 @@ public AlwaysStringKryoMessageConverter kryoOverrideMessageConverter() {

/**
* Even though this MessageConverter has nothing to do with Kryo it still shows
* how Kryo conversion can be customized/overriden since it simply overriding a
* how Kryo conversion can be customized/overridden since it simply overriding a
* converter for contentType 'application/x-java-object'.
*
*/
Expand Down
12 changes: 3 additions & 9 deletions ...d-stream/src/test/java/org/springframework/cloud/stream/binder/MessageConverterTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
import org.springframework.messaging.support.GenericMessage;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.fail;
import static org.assertj.core.api.Assertions.assertThatThrownBy;

/**
* @author Gary Russell
Expand Down Expand Up @@ -127,14 +127,8 @@ void headerEmbeddingMissingHeader() throws Exception {
void badDecode() throws Exception {
byte[] bytes = new byte[] { (byte) 0xff, 99 };
Message<byte[]> message = new GenericMessage<>(bytes);
try {
EmbeddedHeaderUtils.extractHeaders(message, false);
fail("Exception expected");
}
catch (Exception e) {
String s = EmbeddedHeaderUtils.decodeExceptionMessage(message);
assertThat(e).isInstanceOf(BufferUnderflowException.class);
}
assertThatThrownBy(() -> EmbeddedHeaderUtils.extractHeaders(message, false))
.isInstanceOf(BufferUnderflowException.class);
}

}