Skip to content

Use of Config server/Credhub with a client with the propertie spring.cloud.config.name with multi names #1873

Open

Description

@JulianAffaire

Describe the bug
In the client app i have the configuration:
spring.cloud.config.name=nomapp,application,nom2

The problem is that the config server want to load the file (see in actuator/env of the app):
{"name":"bootstrapProperties-credhub-nomapp,application,nom2-cloud-master","properties":{}}

But it's not possible to add in Credhub a secret with a path separated with commas.

If i try with "spring.cloud.config.name=nomapp" it worked.

Is it possible to do that? Or is it a futur feature?

Thank you

Activity

  1. JulianAffaire commented on May 5, 2021

    @JulianAffaire
    Author

    I guess in CredhubEnvironmentRepository :
    environment.add(new PropertySource("credhub-" + application + "-" + profile + "-" + label,findProperties(application, profile, label)));

    You use application string. But if it contains comma you will have my problem. Maybe you should replace comma by underscore ? Or iterated over application names.

  2. spencergibb commented on Jun 3, 2021

    @spencergibb
    Member

    PRs welcome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions