fix: hide Git delivery console windows on Windows - #45
Open
symmr wants to merge 1 commit into
Open
Conversation
The Git delivery watcher spawned visible git consoles because _subprocess_runner did not pass CREATE_NO_WINDOW. Match the update-check path from splunk#19 without importing app.py. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_subprocess_runnernow passes the same WindowsCREATE_NO_WINDOWkwargs as the update-check path, sogit.exeno longer flashes a console every 5 minutes.GitDeliveryService(not imported fromapp.py) to avoid a circular import.test_subprocess_runner_hides_windows_console.Fixes #32
Validation
python -m unittest tests.GitDeliveryScannerTests.test_subprocess_runner_hides_windows_console tests.GitDeliveryScannerTests.test_git_command_uses_path_git— passgit_delivery.py; no visible git consoles during watcher bursts/health:ok=true,inventory_ready=true;meter.err.logemptyFull
tests.test_git_deliverystill hits pre-existing Windows tempfile SQLite cleanupWinError 32on several tests; unrelated to this change.Notes
Same flags as #19 (
creationflags=0x08000000,close_fds=True), different call site.Made with Cursor