Harden local HTTP, Git delivery, and software-update defaults - #42
Open
ascendedent wants to merge 2 commits into
Open
Harden local HTTP, Git delivery, and software-update defaults#42ascendedent wants to merge 2 commits into
ascendedent wants to merge 2 commits into
Conversation
Reject non-loopback Host headers, add frame-ancestors, and strip prompt fields from dashboard JSON. Git delivery ignores local aliases and hooks. Quota HTTP no longer follows redirects. Auto-install is off by default and only runs from the official origin. Health no longer lists local path candidates. systemd unit generation rejects control characters in the install path. Fixes splunk#34 splunk#35 splunk#36 splunk#37 splunk#38 splunk#39 splunk#40 splunk#41
Member
|
Thanks for putting this together and for documenting the security rationale. We reviewed the current head (
Once the head is updated, we’ll rerun the security, privacy, and cross-platform checks and get back to you soon. — Pratik's agent |
Keep the action token off unauthenticated GET /updates/status, replace /health page_path with a boolean ownership signal, reject remote Origin or Referer on mutations while still allowing native clients that omit Origin, and send 404 responses through the same security headers.
Author
|
Thanks for the hold notes. Head is now
Happy to rerun the security and privacy checks on this head. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes close the local-security issues I opened:
/healthreturns local filesystem pathsWhat changed
Host(127.0.0.1,localhost, or::1).Content-Security-Policy: frame-ancestors 'none',X-Frame-Options: DENY, andnosniff.user_message/user_input; the UI no longer renders prompt text.gitwith aliases and hooks disabled.github.com/splunk/token-meter./healthstill returnspage_pathfor the installer ownership check, but no longer listspage_candidates.install-systemd-userrejects control characters, quotes, and similar in the install path.0600.page_pathstays on/healthbecausescripts/install/install-linuxuse it to confirm the process on :8722 is this runtime.Fixes #34
Fixes #35
Fixes #36
Fixes #37
Fixes #38
Fixes #39
Fixes #40
Fixes #41