fix(core): harden SPIFFE URI SAN parsing#434
Open
maxlambrecht wants to merge 1 commit into
Open
Conversation
Signed-off-by: Max Lambrecht <maxlambrecht@gmail.com>
maxlambrecht
force-pushed
the
fix/certificate-spiffe-uri-san-parsing
branch
from
9d9df62 to
59f1192
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Harden
CertificateUtilsSPIFFE ID extraction by filtering Subject Alternative Name entries to URI SANs before casting SAN values, and wrap SPIFFE ID parse failures inCertificateException.Why
Non-URI SAN values can use non-string value types, which could previously cause
ClassCastExceptionbefore the SAN type was checked. Malformed SPIFFE URI SANs could also let unchecked parsing exceptions escape trust validation paths.How tested
Ran:
./gradlew :java-spiffe-core:test --tests io.spiffe.internal.CertificateUtilsTest