Repository navigation
Reject extra CSV records in StringToString arguments - #521
Open
Harshil-1603 wants to merge 2 commits into
Open
Harshil-1603 wants to merge 2 commits into
Harshil-1603 wants to merge 2 commits into
Conversation
Assisted-by: OpenAI gpt-6.1-sol
Assisted-by: OpenAI gpt-6.1-sol
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a map argument contains multiple equals signs, it is parsed as CSV. The parser currently reads only the first record, so an unquoted newline can silently discard later key/value pairs. Reject additional CSV records before updating the flag, while preserving newlines inside correctly quoted fields. Explain this quoting rule in the flag documentation.
Refs #297.
Validation: the full race-enabled test suite, vet, configured golangci-lint and formatting passed. The new regression failed before the fix; a quoted embedded newline remains accepted, and rejected input leaves the default value and Changed state intact.
AI assistance: OpenAI Codex, gpt-6.1-sol.