Update dataset editor file browser modal to use spx theme css#292
Open
klpoland wants to merge 3 commits into
Open
Update dataset editor file browser modal to use spx theme css#292klpoland wants to merge 3 commits into
klpoland wants to merge 3 commits into
Conversation
|
Review changes with Changed Files |
klpoland
added
feature
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
lucaspar
reviewed
Jun 4, 2026
| aria-hidden="true" | ||
| tabindex="-1"> | ||
| <i class="bi bi-file-earmark" aria-hidden="true"></i> | ||
| <span class="file-browser-name">${file.name}</span> |
Member
There was a problem hiding this comment.
wrap user-defined fields like file.name in escapeHtml
| rowSpan.innerHTML = ` | ||
| <span class="item-content"> | ||
| <i class="bi ${folderIcon}"></i> | ||
| ${content.name || name} |
Member
There was a problem hiding this comment.
wrap user-defined fields in escapeHtml
Comment on lines
+1248
to
+1254
| rowSpan.className = "file-browser-row" | ||
| rowSpan.setAttribute("role", "button") | ||
| rowSpan.setAttribute("tabindex", "0") | ||
| rowSpan.setAttribute( | ||
| "aria-expanded", | ||
| initiallyExpanded ? "true" : "false", | ||
| ) |
Member
There was a problem hiding this comment.
rowSpan also needs a keydown handler to work with keyboard, one that runs the same function as the click listener below
|
|
||
| const rowSpan = document.createElement("span") | ||
| rowSpan.className = "file-browser-row" | ||
| rowSpan.setAttribute("role", "button") |
Member
There was a problem hiding this comment.
if the parent has role "tree", I think this should be "treeitem"
|
|
||
| const rowSpan = document.createElement("span") | ||
| rowSpan.className = "file-browser-row" | ||
| rowSpan.setAttribute("role", "option") |
Member
There was a problem hiding this comment.
if the parent has role "tree", I think this should be "treeitem"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.