Repository navigation
ci: run workflows on Node 24 and pin actions to commit SHAs - #135
Merged
Merged
Conversation
Dependabot writes lockfiles with npm 11, which npm 10.9 (Node 22) rejects in npm ci. Also pin every action to a SHA and fix the template-injection, cache-poisoning, and excessive-permissions findings so the bulwark zizmor scan passes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Linus-SpectroCloud
approved these changes
Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe the Change
This PR moves the workflows from Node 22 to Node 24 so that Dependabot's npm PRs can pass CI, and fixes the zizmor findings in
release.yamlandtest.yamlso that bulwark doesn't block this PR or future Actions bumps.Why Node 24. Dependabot regenerates
package-lock.jsonwith npm 11. Node 22 ships npm 10.9, which rejects those lockfiles (npm ci:Missing: conventional-commits-filter@6.0.1 ... from lock file). That's why "Docker Dev image" and "Semantic Release Dry Run" fail on #130–#134, and it's the same drift #127 fixed by hand last month. hello-universe already runs on Node 24 and doesn't have this problem.Changes
NODE_VERSIONgoes from"22"to"24"in both workflows.# vX.Y.Zcomment, which zizmor'sunpinned-usesrule requires. Floating tags (@v7,@v4) are pinned to the commit they resolve to today, so the code that runs doesn't change. Dependabot keeps SHA pins and their comments up to date.docker/setup-buildx-actionis pinned at v4.4.1 anddocker/build-push-actionat v7.4.0. These are the versions in chore: bump docker/setup-buildx-action from 4.3.0 to 4.4.1 #128 and chore: bump docker/build-push-action from 7.3.0 to 7.4.0 #129, which this PR supersedes; Dependabot should close them once it merges.$GITHUB_REPOSITORY,$GITHUB_WORKFLOW, and$GITHUB_SHAinstead of expanding${{ github.* }}into the script (fixestemplate-injection).package-manager-cache: falseis set on setup-node in the two jobs that push images (fixescache-poisoning). This changes nothing at runtime becausepackage.jsonhas nopackageManagerfield.packages: writemoves from the workflow level to thedockerjob, the only job that pushes to GHCR (fixesexcessive-permissions).Review Changes
Verified locally:
excessive-permissionsand Lowartipacked, which already existed and don't trigger the bulwark review.npm cipasses on Node 24 against bothmain's lockfile and the lockfiles in chore: bump @commitlint/config-conventional from 21.2.0 to 21.2.3 #130–chore: bump semantic-release from 25.0.8 to 25.0.9 #134. All of those fail on npm 10.9.GET /repos/{owner}/{repo}/commits/{tag}.After this merges, comment
@dependabot rebaseon #130–#134.🎫 Jira Ticket: none
🤖 Generated with Claude Code