Skip to content

Fix (Split View): Use full width after split view is hidden - #8633

Open
CarolineDenis wants to merge 1 commit into
issue-8627from
issue-8625
Open

CarolineDenis wants to merge 1 commit into
issue-8627from
issue-8625

Conversation

@CarolineDenis

@CarolineDenis CarolineDenis commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #8625

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR
  • Add migration function to
    def fix_schema_config(stdout: WriteToStdOut | None = None):

Testing instructions

  • Resize the results view to be narrower or larger
  • Click on the multi-pane icon to hide the form view
  • Verify that the results view is taking the full width of the screen automatically

Summary by CodeRabbit

  • Bug Fixes
    • Split panes now reset their position when the layout orientation changes or split mode is turned off.

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 6fe21c62-732b-4560-aa52-68629aae8969
📥 Commits

Reviewing files that changed from the base of the PR and between e584a60 and a7f410b.

📒 Files selected for processing (2)
  • specifyweb/frontend/js_src/lib/components/QueryBuilder/SplitView.tsx
  • specifyweb/frontend/js_src/lib/components/QueryBuilder/__tests__/SplitView.test.tsx

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


📝 Walkthrough

Walkthrough

SplitView now resets the primary-pane position when its orientation changes or when split mode changes from enabled to disabled. Tests verify the reset behavior and confirm that the initial render does not reset the pane.

Changes

SplitView pane reset

Layer / File(s) Summary
Reset pane size when split mode closes
specifyweb/frontend/js_src/lib/components/QueryBuilder/SplitView.tsx, specifyweb/frontend/js_src/lib/components/QueryBuilder/__tests__/SplitView.test.tsx
SplitView tracks the previous split-mode value and clears the primary-pane position when split mode changes from enabled to disabled. Tests check that the initial render does not reset the pane and that disabling split mode does. The orientation-change test clears prior mock calls before checking behavior.

Suggested reviewers: grantfitzsimmons

Priority: ➖ Normal

Change: Bug fix · Severity of issue fixed: Medium

Merge Risk: ⚪ Minimal · up to a7f41

Hiding the form allows the results view to fill the available width. No issue requiring a pre-merge fix was found.

🚥 Pre-merge checks | ✅ 6
✅ Passed checks (6 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the main change: the results view uses full width after the split view is hidden.
Linked Issues check ✅ Passed Issue #8625 requires the results pane to fill the window after the form pane is hidden. SplitView resets the splitter's primary-pane state when isSplit changes from true to false. SplitView also sets …
Out of Scope Changes check ✅ Passed The SplitView change and its tests directly address issue #8625 by clearing the remembered pane size when split mode is disabled. No unrelated changes are indicated.
Automatic Tests ✅ Passed The PR adds an automated SplitView test for the behavior that caused the reported issue. It verifies that the initial render does not reset the pane and that changing isSplit from true to false ca…
Testing Instructions ✅ Passed The testing instructions clearly cover the changed behavior. They ask the tester to resize the results pane, hide the form pane with the split-view toggle, and verify that the results pane expands to …
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@CarolineDenis
CarolineDenis requested a review from a team October 5, 2026 08:03
@CarolineDenis

Copy link
Copy Markdown
Contributor Author

@CodeRabbit review

@coderabbitai

coderabbitai Bot commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@rijulpoudel
rijulpoudel self-requested a review October 5, 2026 13:45

@rijulpoudel rijulpoudel left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Resize the results view to be narrower or larger
  • Click on the multi-pane icon to hide the form view
  • Verify that the results view is taking the full width of the screen automatically

Compared with main side by side and the results view is taking the full width of the screen.
https://github.com/user-attachments/assets/697d38c7-9a95-449e-b47e-6fe88f3daa6b

@gabek96 gabek96 left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Resize the results view to be narrower or larger
  • Click on the multi-pane icon to hide the form view
  • Verify that the results view is taking the full width of the screen automatically

Screen.Recording.2026-10-05.at.8.59.27.AM.mov

Looks great! Everything works, I used the ojsmnh_2025_09_09

@JDAM2k4 JDAM2k4 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing instructions

  • Resize the results view to be narrower or larger
  • Click on the multi-pane icon to hide the form view
  • Verify that the results view is taking the full width of the screen automatically

This works just fine on both queries and data view.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋Back Log

Development

Successfully merging this pull request may close these issues.

In Data Views, resizing results view and hiding the form leaves it collapsed

4 participants