Fix (Split View): Use full width after split view is hidden - #8633
CarolineDenis wants to merge 1 commit into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (2)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. 📝 WalkthroughWalkthroughSplitView now resets the primary-pane position when its orientation changes or when split mode changes from enabled to disabled. Tests verify the reset behavior and confirm that the initial render does not reset the pane. ChangesSplitView pane reset
Suggested reviewers: Priority: ➖ Normal Change: Bug fix · Severity of issue fixed: Medium Merge Risk: ⚪ Minimal · up to Hiding the form allows the results view to fill the available width. No issue requiring a pre-merge fix was found. 🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@CodeRabbit review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Testing instructions
- Resize the results view to be narrower or larger
- Click on the multi-pane icon to hide the form view
- Verify that the results view is taking the full width of the screen automatically
Compared with main side by side and the results view is taking the full width of the screen.
https://github.com/user-attachments/assets/697d38c7-9a95-449e-b47e-6fe88f3daa6b
There was a problem hiding this comment.
Testing instructions
- Resize the results view to be narrower or larger
- Click on the multi-pane icon to hide the form view
- Verify that the results view is taking the full width of the screen automatically
Screen.Recording.2026-10-05.at.8.59.27.AM.mov
Looks great! Everything works, I used the ojsmnh_2025_09_09
JDAM2k4
left a comment
There was a problem hiding this comment.
Testing instructions
- Resize the results view to be narrower or larger
- Click on the multi-pane icon to hide the form view
- Verify that the results view is taking the full width of the screen automatically
This works just fine on both queries and data view.
Fixes #8625
Checklist
self-explanatory (or properly documented)
specify7/specifyweb/specify/management/commands/run_key_migration_functions.py
Line 50 in ea04665
Testing instructions
Summary by CodeRabbit