test: isolate overlay parse fixture from parallel readers - #267
Merged
Merged
Conversation
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 1 file
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Test-only change fixes a race by copying the shared overlay fixture into t.TempDir() before formatting and parsing, so parallel tests no longer read a truncated file. The change is focused, preserves existing assertions, and carries no production or operational impact.
Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would auto-approve. Test-only change isolates the shared overlay fixture by copying it into t.TempDir() before formatting and parsing, fixing the parallel-read race; the README addition is a documentation-only Codecov badge. No production or operational behavior changes.
Re-trigger cubic
Contributor
📊 Test Coverage ReportCurrent Statement Coverage: Coverage Change: ✅ No change Statement Coverage by PackageGo measures covered statements. Codecov measures fully covered lines, so its percentage can differ.
📋 Detailed Coverage by Function (click to expand)
Generated by GitHub Actions |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The coverage job on main failed
TestApplyTobecauseTestParseformats the same overlay fixture that parallel apply tests read.Formatusesos.WriteFile, so a reader can see the file while it is truncated and parse an empty overlay. The apply test then compares the unchanged input against the overlaid snapshot.What changed
t.TempDir()before formatting and parsing it.Review notes
Testing
GOTOOLCHAIN=go1.26.0 mise test -count=20 -coverpkg=./... ./overlay: passed with race detection, 2,305 tests and 20 skips.GOTOOLCHAIN=go1.26.0 mise ci: passed locally, including format, dependency checks, lint, tests, CLI integration tests and build.