test: improve library coverage and reporting - #263
Open
TristanSpeakEasy wants to merge 4 commits into
Open
TristanSpeakEasy wants to merge 4 commits into
TristanSpeakEasy wants to merge 4 commits into
Conversation
TristanSpeakEasy
added
tests
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
All reported issues were addressed across 26 files
Shadow auto-approve: would not auto-approve because issues were found.
Tip: instead of fixing issues one by one fix them all with cubic
Re-trigger cubic
Contributor
📊 Test Coverage ReportCurrent Statement Coverage: Coverage Change: 📈 +3.9% (improved) Statement Coverage by PackageGo measures covered statements. Codecov measures fully covered lines, so its percentage can differ.
📋 Detailed Coverage by Function (click to expand)
Generated by GitHub Actions |
There was a problem hiding this comment.
All reported issues were addressed across 11 files (changes from recent commits).
Shadow auto-approve: would not auto-approve because issues were found.
Fix all with cubic | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 1 file (changes from recent commits).
Shadow auto-approve: would not auto-approve because issues were found.
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
There was a problem hiding this comment.
0 issues found across 1 file (changes from recent commits).
Confidence score: 5/5
- Automated review surfaced no issues in the provided summaries.
- No files require special attention.
Shadow auto-approve: would not auto-approve. Auto-approval blocked by 1 unresolved issue from previous reviews.
Re-trigger cubic
Member
Author
|
Coverage and review follow-up status for 8c38f3b:
Latest CI: https://github.com/speakeasy-api/openapi/actions/runs/37249077321 No awesome-go resubmission has been made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The awesome-go submission was closed because Codecov reported 78.2%, below its 80% minimum (maintainer comment). Our Go statement coverage was higher, but that is not the same measure as Codecov's fully covered lines. This adds behavioural tests and fixes coverage collection before we resubmit.
What changed
Review notes
Testing
GOTOOLCHAIN=go1.26.0 mise ci: passed locally, including formatting, module checks, lint/nilaway, examples, library and separate-module tests, CLI integration tests and build.GOTOOLCHAIN=go1.26.0 mise run test-coverage: passed, 8,514 tests with 25 skipped, race detection enabled, 89.2% statement coverage.git diff --check: passed.Summary by cubic
Expands test coverage across the library and fixes the coverage pipeline so Codecov reflects a more accurate, higher percentage. This is the prerequisite for resubmitting to awesome-go, where the prior submission was rejected for reporting 78.2% against the 80% minimum.
Changes
Written for commit 8c38f3b. Summary will update on new commits.