Skip to content

chore(deps): use published ACP and agentkit forks instead of git pins - #256

Merged
danielkov merged 2 commits into
mainfrom
chore/published-acp-forks
Oct 1, 2026
Merged

danielkov merged 2 commits into
mainfrom
chore/published-acp-forks

Conversation

@danielkov

@danielkov danielkov commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Removes every git pin and [patch] section from Cargo.toml.

  • ACP SDK, HTTP transport and schema come from crates.io as agentkit-acp-sdk 2.2.0, agentkit-acp-http 2.2.0 and agentkit-acp-schema 1.9.1. These are the session-injection forks rebased on current upstream. Library names are unchanged.
  • agentkit-acp 0.10.12 (session injection plus David's inline-media budget) and agentkit-loop 0.10.13 replace the daviddanialy/agentkit and danielkov/agentkit git revisions (feat(acp): release ACP v2 session injection behind unstable-inject聽danielkov/agentkit#31).
  • Upstream ACP v2 now requires session/prompt responses to carry the inserted user message id. kit's v2 server returns it, and the mock v2 agents do too.
  • unstable_tool_call_name is dropped; upstream stabilized it.
  • macOS: the pinned v2 schema moves to the published schema source, and ACPPromptResponse gains messageId.

Covers the "replace fork pins" items in #25. kit can move back to the upstream crates once agentclientprotocol/agent-client-protocol#2043 and agentclientprotocol/rust-sdk#339 are released.

Depend on agentkit-acp-sdk, agentkit-acp-http and agentkit-acp-schema from
crates.io and on the released agentkit-acp 0.10.12 / agentkit-loop 0.10.13.
ACP v2 prompt responses now carry the accepted user message id, and the macOS
schema pin follows the published schema source.
kit-code-agent[bot]
kit-code-agent Bot previously approved these changes Oct 1, 2026

@kit-code-agent kit-code-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found. The changes look good to merge.

ACP config options embed the OpenRouter model list, fetched live with a
best-effort fallback, so a fork could advertise a different catalog than its
source when one fetch failed on CI.

@kit-code-agent kit-code-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found. The changes look good to merge.

@danielkov
danielkov enabled auto-merge (squash) October 1, 2026 15:22
@danielkov
danielkov merged commit 3a539bd into main Oct 1, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant