feat: add private network ingress management - #5970
Conversation
|
|
Running ultrareview automatically — This adds a new network-ingress lifecycle API with encrypted credentials, entitlement-gated admission control in MCP/meta-MCP writes, and custom-domain deletion safeguards—subtle bugs here could break access control or leak credentials, so it warrants a deep review.. I'll post findings when complete. |
There was a problem hiding this comment.
Ultrareview completed in 12m 26s
All reported issues were addressed across 91 files
Tip: instead of fixing issues one by one fix them all with cubic
Re-trigger cubic
79accce to
c7a7af4
Compare
There was a problem hiding this comment.
All reported issues were addressed across 25 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 5 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Fix all with cubic | Re-trigger cubic
028aa6c to
b906a5c
Compare
Why
AIS-604 needs a safe management surface for an organization to configure private network ingress before provider reconciliation and traffic serving are enabled. This checkpoint adds that desired-state API while keeping rollout fail-closed and credentials out of API and audit payloads.
Linear: AIS-604
Depends on #5895.
What changed
network_ingressproduct entitlement and an organization-targeted PostHog rollout flag. Reads, explicit disable-only updates, and deletion remain available if rollout is later withdrawn.Review notes
server/internal/networkingress/, especially post-commit signaling and disable/delete behavior after gate removal.nilin this checkpoint; AIS-611 will supply the provider workflow client.checkHealththerefore fails safely until that integration lands.Testing
mise lint:server— passed (sandbox emitted a non-fatal Go module stat-cache permission warning).mise build:server— passed.mise run test:server ./internal/networkingress ./internal/customdomains ./internal/productfeatures ./internal/mcpservers ./internal/metamcp ./internal/admin ./internal/urn -count=1— 1,315 tests passed natively; sandbox could not access the Colima Docker socket.mise run test:server ./internal/networkingress -count=1— passed after one transient Redis I/O timeout during a parallel focused run.mise run lint:webhooks-server— passed; one additive, non-breaking event.git diff --check— passed.Rollout / deployment notes
Summary by cubic
Implements AIS-604 with organization-scoped Tailscale private network ingress management and Kubernetes provisioning support. Network-mode MCP and meta-MCP writes now require a live, enabled ingress, re-checked inside the write transaction via a sealed admission finalizer whose zero value fails closed; expansion remains fail-closed unless both the
network_ingressentitlement and organization rollout flag are enabled.New Features
public_onlyafter gate removal.Written for commit b906a5c. Summary will update on new commits.