fix: stabilize test container startup - #5931
Merged
Merged
Conversation
|
This was referenced Sep 1, 2026
disintegrator
force-pushed
the
demo-seed-safety-flake
branch
from
September 1, 2026 14:14
2f40982 to
775069f
Compare
Contributor
There was a problem hiding this comment.
Auto-approved: review:bypass label applied by @disintegrator. Required status checks still gate this merge.
disintegrator
enabled auto-merge
September 1, 2026 14:18
danielkov
approved these changes
Sep 1, 2026
disintegrator
disabled auto-merge
September 1, 2026 14:19
disintegrator
force-pushed
the
demo-seed-safety-flake
branch
from
September 1, 2026 14:26
775069f to
ae9584c
Compare
disintegrator
force-pushed
the
demo-seed-safety-flake
branch
from
September 1, 2026 14:32
ae9584c to
f8b4692
Compare
disintegrator
force-pushed
the
demo-seed-safety-flake
branch
from
September 1, 2026 14:36
13fac3b to
a3e50fc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
Blacksmith runners can begin a test while Docker's API is temporarily unresponsive. Testcontainers caches its first Docker host discovery result, so a transient
docker infotimeout otherwise prevents every container from starting in that test process. A singleflight preflight makes concurrent container constructors share one bounded readiness attempt and error; later calls can retry a failure, while success remains cached.The ClickHouse image also starts a loopback-only bootstrap server while applying initialization scripts. Waiting through the container hostname prevents that temporary server from satisfying readiness while preserving the existing host-side retry protection.