feat: add private ingress serving observability - #5923
Conversation
|
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
All reported issues were addressed across 20 files
Tip: instead of fixing issues one by one fix them all with cubic
Re-trigger cubic
31a1ea4 to
e008b0f
Compare
|
Addressed all six actionable Cubic observability findings in commit |
e008b0f to
893999a
Compare
893999a to
73f64a2
Compare
Why
The private-ingress stack establishes new serving and trust boundaries, but the earlier checkpoints did not provide a consistent way to distinguish public/private MCP traffic or understand where private admission and authority checks fail. This follow-up adds bounded observability before provisioning work continues.
Stacked on #5922.
What changed
Review notes
Validation
mise run test:server ./internal/netingress ./internal/networkingress ./internal/mcp/mcpmetrics ./internal/mcp ./cmd/gram(817 tests)mise lint:servermise build:servergit diff --checkcubic review -jcould not complete because local Cubic authentication is expired (cubic auth loginrequired)Summary by cubic
Adds the serving observability required by AIS-667 for the private ingress trust boundary: operation and duration metrics for admission, attestation, proxying, endpoint resolution, and OAuth authority revalidation, plus public/private network surface labels on existing MCP metrics. No functional serving behavior changes; the new
netingress-attestorOTel flags are off by default, and only clamped operation/result/reason/provider dimensions are emitted, so no customer data enters metric labels.Review focus
Written for commit 73f64a2. Summary will update on new commits.