Repository navigation
Sprintf-notif triggers for Sparta reports - #690
Merged
Merged
Conversation
Remove assertion for format string in setUsesSprintfNotifTrigger Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: colby-nyce <176335162+colby-nyce@users.noreply.github.com>
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 1, 2026
This feature allows the use of sprintf-style
`ReportDescriptor.dest_file` in yaml files:
```
content:
report:
pattern: _global
def_file: simple_stats.yaml
dest_file: "%s_%i.json"
format: json_reduced
trigger:
sprintf-notif: top.cpu.core0.rob.sprintf_notif
```
Which can be driven by the SprintfNotificationSource class:
```
// Results in report "foo_4.json" being written immediately
sprintf_notif->postNotification("foo", 4);
```
We only support `%s` and `%i` in the format strings.
The existing SimDB reports schema is not well-suited for these yaml
dest_file's. I'd like to split up this task and come back to
sprintf-notif triggers for SimDB to keep this PR focused (and SimDB
reports are not enabled by default yet). The MAP issue for that is here:
#689
---------
Co-authored-by: Colby Nyce <colby.steele.nyce@gmail.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: colby-nyce <176335162+colby-nyce@users.noreply.github.com> ba758c2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature allows the use of sprintf-style
ReportDescriptor.dest_filein yaml files:Which can be driven by the SprintfNotificationSource class:
We only support
%sand%iin the format strings.The existing SimDB reports schema is not well-suited for these yaml dest_file's. I'd like to split up this task and come back to sprintf-notif triggers for SimDB to keep this PR focused (and SimDB reports are not enabled by default yet). The MAP issue for that is here:
#689