[WIP] hip-lang support by scheibelp · Pull Request #4411 · spack/spack-packages

scheibelp · 2026-04-20T22:14:18Z

Apply changes from spack/spack#49673 that apply to spack-packages.

Needs

Interacts with:

Notes:

HIP language support spack#49673 changed SPACK_TEST_COMMAND=dump-env to dump-var, but that would be harder to change (the tests that use this are in spack-core ) and it didn't look essential
I edited a few cases of requires("%[virtuals=c,cxx] llvm-amdgpu") to include when='%c' to accommodate externals that do not specify a compiler (and in a couple cases I swapped requires for depends_on for the same reason)

Other than that this should be a copy of spack/spack#49673

Apply changes from spack/spack#49673 that apply to spack-packages. Co-authored-by: Peter Scheibel <scheibel1@llnl.gov> Signed-off-by: Peter Josef Scheibel <scheibel1@llnl.gov>

scheibelp · 2026-04-20T23:09:06Z

This will have to update the Spack commit used in .ci/env to use at least a5b4056 (from March 27) to pass the package audit (Currently pinned to a commit from March 20)

haampie · 2026-04-21T08:52:48Z

You have to bump the package api

Signed-off-by: Peter Josef Scheibel <scheibel1@llnl.gov>

…rom spack core Signed-off-by: Peter Josef Scheibel <scheibel1@llnl.gov>

… as of March 26, preceding new commit that is used) Signed-off-by: Peter Josef Scheibel <scheibel1@llnl.gov>

Signed-off-by: Peter Josef Scheibel <scheibel1@llnl.gov>

haampie · 2026-04-22T08:15:46Z

    depends_on("zlib-api", type="link")
    depends_on("z3", type="link")
    depends_on("ncurses", type="link")
-    requires("%[virtuals=c,cxx] llvm-amdgpu", when="%c")


The when=%c can be dropped here and elsewhere, right?

I want to be able to create a comgr external without having to specify %llvm-amdgpu on the spec

alalazo

Besides the comment, we may want to delay merging this, so that the next release of the repository is still readable by Spack v1.1

Signed-off-by: Peter Josef Scheibel <scheibel1@llnl.gov>

…ld work more-generally

* extract legion changes for rocm build from #4411 * this issue has been fixed for legion after 26.06

adamjstewart · 2026-09-02T10:12:40Z

+    needs: [hip-compiler]
+  - group: hip-compiler
+    specs:
+    - llvm-amdgpu


What is this?

Language dependents (i.e. things that need compilers), need those providers to be available "before" they concretize, either as an installed package, an external, or as a spec group.

Interesting, so this is still a holdover from when compilers were not dependencies? Hopefully we can bootstrap compilers someday as well, I know Harmen is working on that. Is this something that should also be done for things like rust and cuda? Or are they different because they can be bootstrapped (kinda)?

I'm fine with these changes. Wonder if we should use require instead of prefer, but I defer to you on that.

… is necessary)

adrienbernede · 2026-09-10T08:45:37Z

@scheibelp it looks like CachedCMakePackages should be updated too.

I also created this branch in radiuss-spack-configs to trigger tests of the present PR:
llnl/radiuss-spack-configs#200

It currently fails building camp in our setup.

-- BLT HIP support is ON
-- Creating BLT HIP targets...
-- The HIP compiler identification is unknown
/usr/workspace/radiuss/rsc-ci/shared-ci/corona/zen/ref-woptim-test-spack-packages-pr-4411/install/[padded-to-128-chars]/linux-rhel8-zen/none-none/compiler-wrapper-1.2.0-u3zmgx5lweuq63gqi5macchrxwqy5ibp/libexec/spack/rocmcc/spackhip: line 213: exec: None: not found
CMake Error at /opt/rocm-6.4.3/lib/cmake/hip-lang/hip-lang-config.cmake:139 (message):
  hip-lang Error:127 - clangrt builtins lib could not be found.
Call Stack (most recent call first):
  /usr/tce/backend/installations/linux-rhel8-x86_64/gcc-10.3.1/cmake-3.25.2-2p7loskhisrpohhvpwdmse2nadqgzqcb/share/cmake-3.25/Modules/CMakeHIPInformation.cmake:146 (find_package)
  /usr/workspace/radiuss/rsc-ci/shared-ci/corona/zen/ref-woptim-test-spack-packages-pr-4411/install/[padded-to-128-chars]/linux-rhel8-zen/none-none/blt-0.7.2-kl55lhkpwul6ozj6bovps4ccjug4iogl/cmake/thirdparty/BLTSetupHIP.cmake:14 (enable_language)
  /usr/workspace/radiuss/rsc-ci/shared-ci/corona/zen/ref-woptim-test-spack-packages-pr-4411/install/[padded-to-128-chars]/linux-rhel8-zen/none-none/blt-0.7.2-kl55lhkpwul6ozj6bovps4ccjug4iogl/cmake/BLTSetupTargets.cmake:118 (include)
  /usr/workspace/radiuss/rsc-ci/shared-ci/corona/zen/ref-woptim-test-spack-packages-pr-4411/install/[padded-to-128-chars]/linux-rhel8-zen/none-none/blt-0.7.2-kl55lhkpwul6ozj6bovps4ccjug4iogl/cmake/SetupThirdParty.cmake:6 (include)
  /usr/workspace/radiuss/rsc-ci/shared-ci/corona/zen/ref-woptim-test-spack-packages-pr-4411/install/[padded-to-128-chars]/linux-rhel8-zen/none-none/blt-0.7.2-kl55lhkpwul6ozj6bovps4ccjug4iogl/SetupBLT.cmake:129 (include)
  cmake/load_blt.cmake:27 (include)
  CMakeLists.txt:48 (include)
-- Configuring incomplete, errors occurred!

I may need to update the hip config, or does this suppose an update of Spack itself ?

scheibelp · 2026-09-14T21:13:09Z

@adrienbernede thanks for trying that. I'm wondering if you haven't added hip: to the compilers: extra attribute for llvm-amdgpu

    llvm-amdgpu:
      buildable: false
      externals:
      - spec: llvm-amdgpu@7.2.1
        prefix: /opt/rocm...
        extra_attributes:
          compilers:
            c: ...
            cxx: ...
            fortran: ...
            hip: (same thing as cxx, usually) <-------

I see in your pipeline concretization that it's choosing an external llvm-amdgpu, but didn't see a change to packages.yaml in your PR

I'm able to build camp+rocm with this PR (example config for llvm-amdgpu is in stacks/e4s-rocm-external/spack.yaml.

spackbot-triage Bot added dependencies Modifications with a `depends_on()` directive virtual-dependencies Modifications to virtual package dependencies update-package Modifications to packages in the repository labels Apr 20, 2026

spackbot-triage Bot requested review from afzpatel, haampie, renjithravindrankannath and srekolam April 20, 2026 22:14

hip-lang support

215bd48

Apply changes from spack/spack#49673 that apply to spack-packages. Co-authored-by: Peter Scheibel <scheibel1@llnl.gov> Signed-off-by: Peter Josef Scheibel <scheibel1@llnl.gov>

scheibelp force-pushed the hip-lang branch from 7f1e261 to 215bd48 Compare April 20, 2026 22:16

scheibelp added 2 commits April 21, 2026 09:58

this is a change in package API: update version

4fc37c2

Signed-off-by: Peter Josef Scheibel <scheibel1@llnl.gov>

update spack checkout version to include necessary hip-lang support f…

b56eae9

…rom spack core Signed-off-by: Peter Josef Scheibel <scheibel1@llnl.gov>

scheibelp requested a review from a team as a code owner April 21, 2026 18:28

scheibelp added the don't-merge-yet label Apr 21, 2026

error output is different for new installer (new installer is default…

ecbc782

… as of March 26, preceding new commit that is used) Signed-off-by: Peter Josef Scheibel <scheibel1@llnl.gov>

scheibelp requested review from alalazo, becker33, johnwparent and tldahlgren as code owners April 21, 2026 19:08

spackbot-triage Bot added the tests General test capability(ies) label Apr 21, 2026

style error

5c2a130

Signed-off-by: Peter Josef Scheibel <scheibel1@llnl.gov>

haampie reviewed Apr 21, 2026

View reviewed changes

Comment thread repos/spack_repo/builtin/build_systems/rocm.py Outdated

use newer virtual= syntax

ab2d917

Signed-off-by: Peter Josef Scheibel <scheibel1@llnl.gov>

spackbot-triage Bot requested a review from haampie April 21, 2026 22:51

haampie reviewed Apr 22, 2026

View reviewed changes

alalazo requested changes Apr 29, 2026

View reviewed changes

Comment thread repos/spack_repo/builtin/repo.yaml Outdated

version is updating to 2.5

e63e5ac

Signed-off-by: Peter Josef Scheibel <scheibel1@llnl.gov>

spackbot-triage Bot requested a review from haampie April 29, 2026 17:31

scheibelp mentioned this pull request Apr 29, 2026

updates to aotriton , composable-kernel, miopen-hip packages. #4205

Merged

scheibelp added 3 commits August 12, 2026 13:13

import moved, but has been available since 1.2.1 as a global

d9ae9e8

update comment

6908cc4

replace arch-specific clang_rt lib filtering with something that shou…

04519df

…ld work more-generally

spackbot-triage Bot requested a review from haampie August 13, 2026 02:16

scheibelp added 7 commits August 13, 2026 13:27

rocblas/rocsolver follow rocfft

933c35d

refactor legion parallel for rocm (will extract)

b77e4e8

Merge branch 'develop' into hip-lang

a36232c

explicitly build legion+rocm

0b23cc9

Merge branch 'develop' into hip-lang

d0d2704

rocblas/rocsolver should use amdclang++

11a2a03

set ROCM_PATH for realm

9c1ba50

scheibelp mentioned this pull request Aug 17, 2026

legion: disable parallel build for +rocm #6121

Merged

point to latest commit of compiler wrapper

c973eda

rbberger pushed a commit that referenced this pull request Aug 19, 2026

legion: disable parallel build for +rocm (#6121)

c61cfa7

* extract legion changes for rocm build from #4411 * this issue has been fixed for legion after 26.06

scheibelp added 3 commits September 1, 2026 11:23

merge from develop (minor conflict in legion)

290f35d

point to newest compiler wrapper update

3963d7f

spec group needs llvm-amdgpu pre-concretized

48fed55

scheibelp requested a review from adamjstewart as a code owner September 2, 2026 07:20

adamjstewart reviewed Sep 2, 2026

View reviewed changes

scheibelp added 2 commits September 2, 2026 11:47

generally use gcc for ml-linux-x86_64 stack (except where llvm-amdgpu…

c2a4406

… is necessary)

update compiler-wrapper pointer (changes in dependency PR)

998d5c7

spackbot-triage Bot requested review from acfisher, adrienbernede, fryeguy52, jwillenbring, keitat and markcmiller86 September 9, 2026 20:58

merge from develop (minor conflict in stack)

e22386b

Navigation Menu

[WIP] hip-lang support - #4411

[WIP] hip-lang support#4411
scheibelp wants to merge 73 commits into
spack:developfrom
scheibelp:hip-lang

scheibelp commented Apr 20, 2026 •

edited

Loading

Uh oh!

scheibelp commented Apr 20, 2026

Uh oh!

haampie commented Apr 21, 2026

Uh oh!

Uh oh!

haampie Apr 22, 2026

Uh oh!

scheibelp Apr 22, 2026

Uh oh!

alalazo left a comment

Uh oh!

Uh oh!

adamjstewart Sep 2, 2026

Uh oh!

scheibelp Sep 14, 2026

Uh oh!

adamjstewart Sep 15, 2026

Uh oh!

adrienbernede commented Sep 10, 2026

Uh oh!

scheibelp commented Sep 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

Conversation

scheibelp commented Apr 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

scheibelp commented Apr 20, 2026

Uh oh!

haampie commented Apr 21, 2026

Uh oh!

Uh oh!

haampie Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

scheibelp Apr 22, 2026

Choose a reason for hiding this comment

Uh oh!

alalazo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

adamjstewart Sep 2, 2026

Choose a reason for hiding this comment

Uh oh!

scheibelp Sep 14, 2026

Choose a reason for hiding this comment

Uh oh!

adamjstewart Sep 15, 2026

Choose a reason for hiding this comment

Uh oh!

adrienbernede commented Sep 10, 2026

Uh oh!

scheibelp commented Sep 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

12 participants

scheibelp commented Apr 20, 2026 •

edited

Loading