fix(v2d): reject unaligned bitblit destination origins - #52
Open
mingjie-wu-spacemit wants to merge 1 commit into
Open
mingjie-wu-spacemit wants to merge 1 commit into
mingjie-wu-spacemit wants to merge 1 commit into
Conversation
Robot CI AI Review
结论:暂无明确问题。 备注:worker-cache review 失败,已回退 baseline review:worker-cache review failed: snode5: fetch base failed: From github.com:spacemit-com/mpp |
mingjie-wu-spacemit
force-pushed
the
fix/v2d-bitblit-crop-alignment
branch
from
September 16, 2026 09:25
878f684 to
4e2cc95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
V2D_AddBitblitTask uses the destination rectangle as the hardware output crop. A non-16-aligned origin, such as (0, 140) for a 640x360 RGB image in a 640x640 destination, can trigger a V2D hardware error and corrupt the output even when V2D_EndJob returns success.
Reject unaligned destination X/Y origins with V2D_ERR_INVALID_PARAM before queuing the task, log the coordinates and alignment requirement, and document the restriction in the public API. Source rectangle origins are unaffected.
Validation on SpacemiT K3: