Stop runtime activity indicator flickering between scans - #82
Merged
kentwelcome merged 1 commit intoAug 24, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR prevents the runtime activity indicator from flickering to idle during workflow snapshot reloads by carrying forward previously published EntityActivity (and related scan diagnostics) when the reloaded snapshot still contains the same entity identity (matching id + source path). This aligns with Spacetop’s read-first operator experience by keeping “currently running” signals stable across refresh cycles.
Changes:
- Add
WorkflowIndex::retain_session_activity_fromto selectively transfer prior session activity (and scan error) only when entity identity is unchanged across reloads. - Update
OverviewState::reload_from_indexto retain activity during snapshot reloads instead of clearing it. - Add multi-cycle reload + polling + stop UI regression coverage and an app-level reload retention test; document the retention semantics in the activity design spec.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| docs/superpowers/specs/2026-07-27-spacetop-entity-activity-design.md | Documents the intended behavior: retain activity/diagnostics across reloads only for unchanged entity identity. |
| crates/spacetop/src/ui/tests/task_list.rs | Adds a 5-cycle reload + unchanged scan loop asserting the running marker/text remains stable, then validates stop behavior. |
| crates/spacetop/src/ui/tests.rs | Refactors test helpers to share snapshot_with_items for reuse in UI tests. |
| crates/spacetop/src/app/tests.rs | Adds an app-level regression test ensuring activity survives reload_from_snapshot when entity identity is unchanged. |
| crates/spacetop/src/app/overview.rs | Implements the behavior change by retaining prior session activity on index reload rather than clearing it. |
| crates/spacetop-core/src/index.rs | Introduces the core retention logic and adds focused unit tests for identity-preserving vs identity-changing reloads. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
kentwelcome
deleted the
spacedock-ensign/stabilize-runtime-activity-indicator
branch
August 24, 2026 02:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep runtime activity visible across workflow refreshes so operators do not see active workers flicker to idle.
What changed
Evidence
Review guidance
AC-4 live Engram observation remains unavailable; captain approved publication despite this gap.
078