fix(scripts): supply full default runtime options to bench_collect - #359
Merged
Merged
Conversation
Signed-off-by: Jared Scott <jared.scott@variable.team>
Contributor
CoverageThreshold: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Populate runtime options in
scripts/bench_collect.pyusingcli.build_parser().parse_args([])rather than a hardcodedargparse.Namespace.When new runtime flags (such as
--no-tripwires) were added tocli.build_runtime, the manually constructed Namespace was missing them, causing anAttributeErroron execution. Parsing CLI defaults directly ensures newly added options automatically receive their standard defaults without requiring manual Namespace synchronization.Verification
python3 -m unittest scripts.tests.test_bench_collect(passes, 29 tests)python3 scripts/bench_collect.py --repeat 2(executes successfully with exit code 0)