docs(skills): clarify Spacedock fixture setup - #4
Merged
Conversation
Signed-off-by: Kent Huang <kent@infuseai.io>
There was a problem hiding this comment.
🟢 Approval recommended
The changes are cohesive documentation-and-contract updates with consistent naming, clear safety rationale, and deterministic test enforcement, and no correctness issues were found in the modified files.
Pull request overview
This PR clarifies and hardens the Spacedock fixture setup story used by the Behavior Diff skills by renaming the previously opaque “capsule” helper to an explicit make-spacedock-fixtures.sh, documenting fixture expectations at first mention, and enforcing the new naming/phrasing via the deterministic live-report contract test.
Changes:
- Rename and reword the Spacedock fixture builder script to
make-spacedock-fixtures.sh, including updated diagnostics and theFIXTURES OKvalidation signal. - Update both
behavior-diffandbehavior-diff-liveskills plus the Spacedock duo reference to define fixtures at first use and explain why hand-built workflow state is unsafe. - Strengthen
tests/live-report-contract.shto enforce the new script name, executable path, “no legacy capsule naming” constraints, and the first-use definition contract.
File summaries
| File | Description |
|---|---|
| tests/live-report-contract.sh | Adds deterministic checks for the renamed fixture script, output strings, removal of legacy path, and “definition at first use” requirements across docs. |
| RETRO_NOTES.md | Updates retro guidance to reference make-spacedock-fixtures.sh and improves wording of a Spacedock fixture trap note. |
| plugin/skills/behavior-diff/SKILL.md | Defines Spacedock fixtures at first mention and points to the new fixture builder + reference doc. |
| plugin/skills/behavior-diff/scripts/make-spacedock-fixtures.sh | Implements the renamed fixture builder wording/diagnostics and switches the validation marker to FIXTURES OK. |
| plugin/skills/behavior-diff/references/spacedock-duo.md | Reframes fixtures as binary-created repos, documents the hand-built-state risk, and updates the command/path placeholders. |
| plugin/skills/behavior-diff-live/SKILL.md | Mirrors the headless skill’s first-use fixture definition and references the renamed builder in the sibling skill. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
capsulehelper tomake-spacedock-fixtures.shFIXTURES OKsignalCloses DRC-4280
Test plan
bash tests/hooks-test.shpython3 plugin/skills/behavior-diff/scripts/decisions.py --checkbash tests/live-report-contract.shbash tests/release-workflow-test.shdocker run --rm -v "$PWD:/mnt" -w /mnt mvdan/shfmt:v3.14.0 -d -i 2 -ci .uvx ruff@0.16.5 format --check --diff .