ci: publish Behavior Diff releases to marketplace - #2
Merged
Conversation
Signed-off-by: Kent Huang <kent@infuseai.io>
Signed-off-by: Kent Huang <kent@infuseai.io>
Signed-off-by: Kent Huang <kent@infuseai.io>
Signed-off-by: Kent Huang <kent@infuseai.io>
Signed-off-by: Kent Huang <kent@infuseai.io>
Signed-off-by: Kent Huang <kent@infuseai.io>
Signed-off-by: Kent Huang <kent@infuseai.io>
There was a problem hiding this comment.
🟡 Changes recommended
There are a couple of concrete secret-safety hardening issues (deploy key file creation permissions and predictable temp file naming) that should be addressed before merging.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR adds a stable GitHub Release-driven publication flow for Behavior Diff, reusing deterministic CI and updating the Spacedock marketplace entry in a controlled, test-validated way, while also updating operator-facing documentation.
Changes:
- Add a
release.publishedworkflow that reuses CI, validates release tags/manifests, and pushes a pinned marketplace update via deploy key. - Add a deterministic shell updater + contract test to enforce marketplace mutation and workflow safety invariants.
- Update README/operator docs and verification docs to reflect the new release process and checks.
File summaries
| File | Description |
|---|---|
.github/workflows/release.yml |
New Release workflow: validates tag/manifests/main ancestry, then updates marketplace via deploy key. |
.github/workflows/ci.yml |
Makes CI reusable via workflow_call and runs the new release workflow contract test. |
.github/scripts/update-marketplace.sh |
Adds a deterministic JSON updater for marketplace version + source.ref. |
tests/release-workflow-test.sh |
Adds a contract test covering updater behavior and workflow security/structure invariants (incl. non-force push). |
README.md |
Updates install/usage text and documents the operator release steps. |
AGENTS.md |
Adds tests/release-workflow-test.sh to the documented deterministic suite. |
CODING_GUIDELINES.md |
Updates verification commands to include new scripts and the release workflow test. |
plans/2026-09-02-plugin-release-process.md |
Adds an implementation plan for the release workflow + marketplace updater + ops steps. |
plans/2026-09-02-plugin-release-design.md |
Adds the release design/contract describing workflow behavior and constraints. |
Review details
- Files reviewed: 9/9 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Kent Huang <kent@infuseai.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mainancestry, and both plugin manifests.versionandsource.ref.Security and operations
contents: readin Behavior Diff.MARKETPLACE_DEPLOY_KEY, not a personal token.Test plan
docker run --rm -v "$PWD:/mnt" -w /mnt mvdan/shfmt:v3.14.0 -d -i 2 -ci .uvx ruff@0.16.5 format --check --diff .rhysd/actionlint:1.7.7bash tests/hooks-test.shpython3 plugin/skills/behavior-diff/scripts/decisions.py --checkbash tests/live-report-contract.shbash tests/release-workflow-test.shclaude plugin validate plugingit diff --checkReview
Generated with OpenAI Codex