Repository navigation
Conversation
eseliger
changed the title
eseliger
force-pushed
the
deduplicate-symbol-information
branch
from
August 23, 2026 00:08
af77128 to
b6997da
Compare
eseliger
marked this pull request as ready for review
August 23, 2026 00:23
christoph-sg
force-pushed
the
deduplicate-symbol-information
branch
from
September 10, 2026 13:33
b6997da to
d1877d4
Compare
christoph-sg
force-pushed
the
deduplicate-symbol-information
branch
from
September 11, 2026 08:58
d1877d4 to
5b644a6
Compare
christoph-sg
force-pushed
the
deduplicate-symbol-information
branch
from
September 11, 2026 09:03
5b644a6 to
722f92e
Compare
christoph-sg
force-pushed
the
deduplicate-symbol-information
branch
from
September 11, 2026 09:16
722f92e to
702fa82
Compare
christoph-sg
force-pushed
the
deduplicate-symbol-information
branch
from
September 11, 2026 09:27
702fa82 to
f17bea7
Compare
christoph-sg
force-pushed
the
deduplicate-symbol-information
branch
from
September 11, 2026 09:44
f17bea7 to
5b4ea78
Compare
eseliger
force-pushed
the
deduplicate-symbol-information
branch
from
September 30, 2026 17:43
5b4ea78 to
3707e62
Compare
eseliger
force-pushed
the
deduplicate-symbol-information
branch
from
October 1, 2026 08:24
3707e62 to
4fa4ad2
Compare
christoph-sg
requested changes
Oct 1, 2026
christoph-sg
left a comment
christoph-sg
left a comment
Contributor
There was a problem hiding this comment.
Just one small question, otherwise looks good.
Comment on lines
+404
to
+405
| if (!existing.documentation.includes(documentation)) { | ||
| existing.documentation.push(documentation) |
Contributor
There was a problem hiding this comment.
Merging the two documentation strings seems worse than just picking the first non-empty one. WDYT?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Emit one
SymbolInformationrecord per SCIP symbol. Overload declarations merge their unique documentation and relationships—including definition relationships—into the first record instead of emitting duplicate metadata.The overload snapshot renders both overload signatures beneath one symbol, providing a focused regression test for the merge behavior.
Running against the vscode codebase, the memory impact is minimal.
This was reported by
scip linton a large repo.