Repository navigation
feat: inline help text, focus-on-mode-switch, validation live region, longer copy status (#100, #101, #102, #103) - #244
Open
UFObject247 wants to merge 1 commit into
Conversation
…er copy status (soroban-testkit#100, soroban-testkit#101, soroban-testkit#102, soroban-testkit#103) - soroban-testkit#100: Associate inline help text with every form field. All required and optional inputs, selects, and checkboxes now carry aria-describedby pointing to a visible .field-help element, making each field's purpose and expected value discoverable by screen readers without trial and error. - soroban-testkit#101: Move focus to the workflow heading after a mode switch. Clicking the coverage / limits / audit tab buttons now moves focus to the "From intent to command" h2, giving keyboard and screen-reader users an unambiguous entry point into the updated form. - soroban-testkit#102: Announce validation errors through a live region. The Copy button now validates required fields before writing to the clipboard. The first unsatisfied constraint is announced via an aria-live="assertive" region; the error clears when the field is filled. - soroban-testkit#103: Make the copied status persist long enough for assistive technology. Reset timeout extended from 1 600 ms to 3 000 ms so screen readers and Braille displays have enough time to announce the state change. Adds focused tests for each behaviour and updates docs/accessibility.md with new automated-check entries and findings 11–14.
|
@UFObject247 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #100
Closes #101
Closes #102
Closes #103
Four focused accessibility enhancements to the Soroban Testkit Interface.
#100 — Inline help text for form fields
Every required and optional input, select, and checkbox in the command builder now carries an
aria-describedbyattribute pointing to a visible.field-helpelement. Screen reader users can now discover each field's purpose and expected value without trial and error.#101 — Focus moves to the workflow heading after a mode switch
Clicking the coverage / limits / audit tab buttons now moves focus to the "From intent to command"
h2(viatabIndex={-1}+ auseEffectthat skips the first render). Keyboard and screen-reader users land at the top of the updated form instead of staying on the tab button.#102 — Validation errors announced via live region
The Copy button now runs validation before writing to the clipboard. The first unsatisfied constraint is announced through an
aria-live="assertive"+role="alert"region, and the message clears as soon as the field is corrected. The clipboard is never written when validation fails.#103 — Copied status persists long enough for assistive technology
The reset timeout for all copy buttons (Copy, Copy with comments, Copy as script, step Copy buttons) has been extended from 1 600 ms to 3 000 ms. This gives screen readers and Braille displays enough time to announce the state change before it reverts.
Test plan
src/App.test.tsx)docs/accessibility.mdupdated with new automated-check entries and findings 11–14🤖 Generated with Claude Code