Skip to content

Add page titles, not-found handling, download, and history features - #241

Merged
SarahDoma merged 1 commit into
soroban-testkit:mainfrom
d-plug:feature/issues-136-137-146-147
Oct 21, 2026
Merged

SarahDoma merged 1 commit into
soroban-testkit:mainfrom
d-plug:feature/issues-136-137-146-147

Conversation

@d-plug

@d-plug d-plug commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

This PR implements four related UI enhancements to improve user experience:

Features Implemented

#136 - Visible page title for deep-linked views

  • Added an h1 page title when viewing module details
  • Provides better context for screen readers and when directly linking to module pages
  • Uses sr-only class for visual consistency while maintaining accessibility

#137 - Not-found page for invalid module routes

  • Displays a user-friendly error page when an invalid module is accessed
  • Includes clear messaging and a button to return to the module list
  • Handles edge cases gracefully

#146 - Download action for generated shell script

  • Added a download button next to the copy button in the command builder
  • Downloads commands as properly formatted shell scripts with headers
  • Files are named based on the selected command type (e.g., soroban-testkit-coverage.sh)
  • Includes timestamp and generator comment in the downloaded script

#147 - Session-only command history

  • Tracks all generated commands during the current session
  • Displays history with timestamps in a collapsible panel
  • Allows copying individual commands from history
  • Includes a clear history button
  • History is stored in component state (not persisted across page reloads)

Implementation Details

  • All features follow existing accessibility patterns with ARIA labels
  • Keyboard navigation is fully supported
  • Visual styling is consistent with the existing design system
  • Tests added for all new functionality
  • No breaking changes to existing features

Testing

  • Added comprehensive unit tests for all four features
  • Tests cover user interactions, accessibility, and edge cases
  • Build passes successfully

Closes #136, Closes #137, Closes #146, Closes #147

@drips-wave

drips-wave Bot commented Oct 21, 2026

Copy link
Copy Markdown

@d-plug Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

- Add visible h1 page title for deep-linked module views
- Implement not-found page for invalid module routes
- Add download button for generated shell scripts
- Add history UI to display and manage saved command configurations
- Include comprehensive tests for all new features
@d-plug
d-plug force-pushed the feature/issues-136-137-146-147 branch from 762ca1e to 2c58890 Compare October 21, 2026 16:29
@SarahDoma
SarahDoma merged commit 5883c49 into soroban-testkit:main Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants