Repository navigation
fix(a11y): skip link CSS, audit command reference, output region label, focus indicators (#96–#99) - #238
Open
Emeka-12 wants to merge 1 commit into
Open
fix(a11y): skip link CSS, audit command reference, output region label, focus indicators (#96–#99)#238Emeka-12 wants to merge 1 commit into
Emeka-12 wants to merge 1 commit into
Conversation
…ators (soroban-testkit#96–soroban-testkit#99) - soroban-testkit#96: Add .skip-link CSS rule so the existing skip-to-main-content link appears visually when focused (position absolute, slides into view on :focus) - soroban-testkit#97: Add audit command reference section (id="audit-reference") with ready-to-run command, argument docs, and step-by-step guidance; add it to navSections so it is reachable from the main navigation - soroban-testkit#98: Add :focus-visible outlines (2px solid --color-accent, offset 3px) to .button and .output button so all interactive states meet WCAG AA 3:1 UI component contrast requirement - soroban-testkit#99: Wrap the generated command output in a role="region" named "Generated command output" with an aria-describedby pointer to a visually-hidden description so screen readers announce the region's purpose Tests added for soroban-testkit#96 (skip-link class), soroban-testkit#97 (section exists, nav link, command docs), and soroban-testkit#99 (named region, describedby description). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
@Emeka-12 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.skip-linkCSS so the existing skip-to-main-content<a>becomes visible when focused (slides down from above the viewport with a 0.15s ease transition, styled with the accent color)id="audit-reference"command reference section for the audit workflow (ready-to-run command, argument table, step-by-step guide), and expose it in the main navigation:focus-visibleoutlines (2px solid --color-accent,outline-offset: 3px) to.buttonand.output buttonso all interactive controls meet the WCAG AA 3:1 UI component contrast requirementrole="region"named "Generated command output" with anaria-describedbypointing to a visually-hidden description, so screen readers announce the region's purposeTest plan
<main>and carries classskip-linktabindex="-1"and heading "Audit workflow, at a glance."#audit-reference--strictflagaria-describedbydescriptiontsc --noEmit)🤖 Generated with Claude Code