Repository navigation
Conversation
…estkit#91) Adds a keyboard-accessible checklist of four items to check before running an audit scan (Rust toolchain, wasm target, Testkit CLI, clean build), rendered as a labelled fieldset of checkboxes inside the existing "Audit workflow tutorial" guide panel. Local component state only; nothing persisted.
|
@adenikeakan Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #91
Closes #93
Closes #94
Closes #95
#91 — prerequisites checklist for the audit workflow
Added a labelled
fieldsetof 4 checkboxes (Rust toolchain, wasm32v1-none target, Testkit CLI installed, contract builds clean) inside the existing "Audit workflow tutorial" guide panel (auditGuideOpen/audit-guide-panel). Each item is a standard<label>-wrapped checkbox, so it's keyboard-accessible (native Tab/Space) and screen-reader-accessible (each has its own accessible name) with no extra ARIA needed. State is local component state only — nothing persisted, matching the existing guide-toggle pattern in this file.Added a focused test (
App.test.tsx, "Audit workflow prerequisites checklist (#91)") and a row indocs/accessibility.md's automatic-checks table.#93/#94/#95 — already implemented
I read through
src/App.tsxandsrc/App.test.tsxlooking for where each of these would need to land, and all three are already fully done:handleWorkflowKeyDownalready handles ArrowLeft/ArrowRight/Home/End with wraparound and moves focus to the newly active tab button. The workflow tabs already use the full WAI-ARIA tabs pattern (role="tablist"/"tab"/"tabpanel",aria-selected, rovingtabIndex0/-1). Already covered by an existing test (fireEvent.keyDown(coverageTab, { key: "ArrowRight" }), etc.).aria-pressed={command === name}. Already covered by two existing tests assertingtoHaveAttribute("aria-pressed", "true").aria-labelor is wrapped in a<label>with visible text. I went through every<button>/<input>/<select>in the file; found nothing unnamed.No code changes for these three — closing them as already resolved rather than leaving them open or silently dropping them.
Test plan
node_modulesisn't installed in my environment, and I didn't runnpm installper my own working constraints, so I couldn't runvitest/tsclocally. The new test follows this file's existing query patterns (getByRole("checkbox", { name: ... }),fireEvent.click) closely enough that I'm confident in its shape, but it's unverified by an actual run.