Skip to content

Prerequisites checklist for the audit workflow - #233

Merged
SarahDoma merged 1 commit into
soroban-testkit:mainfrom
adenikeakan:feat/91-93-94-95-audit-prerequisites-checklist
Oct 20, 2026
Merged

SarahDoma merged 1 commit into
soroban-testkit:mainfrom
adenikeakan:feat/91-93-94-95-audit-prerequisites-checklist

Conversation

@adenikeakan

Copy link
Copy Markdown
Contributor

Summary

Closes #91
Closes #93
Closes #94
Closes #95

#91 — prerequisites checklist for the audit workflow

Added a labelled fieldset of 4 checkboxes (Rust toolchain, wasm32v1-none target, Testkit CLI installed, contract builds clean) inside the existing "Audit workflow tutorial" guide panel (auditGuideOpen/audit-guide-panel). Each item is a standard <label>-wrapped checkbox, so it's keyboard-accessible (native Tab/Space) and screen-reader-accessible (each has its own accessible name) with no extra ARIA needed. State is local component state only — nothing persisted, matching the existing guide-toggle pattern in this file.

Added a focused test (App.test.tsx, "Audit workflow prerequisites checklist (#91)") and a row in docs/accessibility.md's automatic-checks table.

#93/#94/#95 — already implemented

I read through src/App.tsx and src/App.test.tsx looking for where each of these would need to land, and all three are already fully done:

  • Feature: Support arrow-key navigation between workflow tabs #93 (arrow-key navigation between workflow tabs): handleWorkflowKeyDown already handles ArrowLeft/ArrowRight/Home/End with wraparound and moves focus to the newly active tab button. The workflow tabs already use the full WAI-ARIA tabs pattern (role="tablist"/"tab"/"tabpanel", aria-selected, roving tabIndex 0/-1). Already covered by an existing test (fireEvent.keyDown(coverageTab, { key: "ArrowRight" }), etc.).
  • Feature: Expose the selected command with an accessible pressed state #94 (accessible pressed state for the selected command): the command-mode buttons already set aria-pressed={command === name}. Already covered by two existing tests asserting toHaveAttribute("aria-pressed", "true").
  • Feature: Add accessible names to all command mode controls #95 (accessible names on all command-mode controls): every control in the command builder (path/function/ramp inputs, format/shell selects, checkboxes, clear buttons) already has either an explicit aria-label or is wrapped in a <label> with visible text. I went through every <button>/<input>/<select> in the file; found nothing unnamed.

No code changes for these three — closing them as already resolved rather than leaving them open or silently dropping them.

Test plan

…estkit#91)

Adds a keyboard-accessible checklist of four items to check before running
an audit scan (Rust toolchain, wasm target, Testkit CLI, clean build),
rendered as a labelled fieldset of checkboxes inside the existing "Audit
workflow tutorial" guide panel. Local component state only; nothing
persisted.
@drips-wave

drips-wave Bot commented Oct 20, 2026

Copy link
Copy Markdown

@adenikeakan Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@SarahDoma
SarahDoma merged commit 9b19cd8 into soroban-testkit:main Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants