Add arm64 aspeed build to CI - #623
Open
saiarcot895 wants to merge 3 commits into
Open
Conversation
Also experiment with building kernel without debug info for faster CI build. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The Makefile’s -P...,$(ADDITIONAL_BUILD_PROFILES) usage can produce a trailing comma when empty (risking build failure), and the new aspeed job may fail if its baseline artifact does not exist for the download/diff step.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a new CI build variant targeting arm64/aspeed and introduces a mechanism to pass extra Debian build profiles to dpkg-buildpackage, with CI configured to experiment with disabling kernel debug info to speed up builds.
Changes:
- Add
ADDITIONAL_BUILD_PROFILESto the top-levelMakefileand thread it intodpkg-buildpackage -P .... - Add an
arm64+aspeedjob toazure-pipelines.ymlusing the shared build template. - Extend
.azure-pipelines/build-template.ymlto allowaspeedas a platform and setADDITIONAL_BUILD_PROFILES=pkg.linux.nokerneldbginfofor CI builds.
File summaries
| File | Description |
|---|---|
| Makefile | Adds support for passing additional dpkg-buildpackage build profiles via ADDITIONAL_BUILD_PROFILES. |
| azure-pipelines.yml | Adds a new CI job for arm64/aspeed builds. |
| .azure-pipelines/build-template.yml | Allows aspeed platform selection and sets an additional build profile for faster CI builds. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+70
to
+74
| arch: arm64 | ||
| platform: aspeed | ||
| pool: sonicso1ES-arm64 | ||
| old_artifact_name: sonic-linux-kernel.aspeed.arm64 | ||
| artifact_name: sonic-linux-kernel.aspeed.arm64 |
Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
|
/azp run |
|
Azure Pipelines: No pipelines were found matching this branch/path. |
Contributor
Author
|
/azp run |
|
Azure Pipelines: No pipelines were found matching this branch/path. |
Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also experiment with building kernel without debug info for faster CI build.