Verify that locally-specified configs are actually getting set - #621
Open
saiarcot895 wants to merge 2 commits into
Open
Verify that locally-specified configs are actually getting set#621saiarcot895 wants to merge 2 commits into
saiarcot895 wants to merge 2 commits into
Conversation
After local configs are set and oldconfig is run, make sure that the configs that we are locally setting are actually staying set. Note that the current code isn't comprehensive, and won't necessarily check to see that something is unset. Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new buildcheck uses print() instead of the provided out writer used by existing checks, which can bypass the caller’s expected output capture/formatting.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a Debian-kernel packaging build-time verification step to confirm that locally provided debian/config.local/* fragments are still reflected in the generated .config after configuration is processed, helping catch cases where oldconfig (or related steps) drop locally requested settings.
Changes:
- Introduces a new
CheckConfigsAreSetcheck in Debian’sdebian/bin/buildcheck.py(via patch) to compare merged local config fragments against the final.config. - Hooks the new check into the
setupphase checks alongside the existing secure-boot check. - Applies the new patch during the kernel source preparation step in the top-level
Makefile.
File summaries
| File | Description |
|---|---|
| patches-debian/verify-local-configs-are-applied.patch | Adds a new Debian buildcheck that compares merged debian/config.local/* config fragments against the resulting .config. |
| Makefile | Applies the new Debian buildcheck patch during the kernel source preparation workflow. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Saikrishna Arcot <sarcot@microsoft.com>
|
/azp run |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After local configs are set and oldconfig is run, make sure that the configs that we are locally setting are actually staying set. Note that the current code isn't comprehensive, and won't necessarily check to see that something is unset.