Fix/issue 942 landingpage loading state#1031
Merged
hman38705 merged 2 commits intoJun 30, 2026
Merged
Conversation
Replace local-only submission handler with actual POST to /api/v1/newsletter/subscribe via the API client. Success and error responses are surfaced to the user. Update existing accessibility tests to mock the API and use waitFor for async assertions. Adds test verifying: - API endpoint is called on valid submission - API errors are displayed to the user
- Introduce isLoading state to gate UI updates during API calls - Disable both the email input and submit button while request is in-flight - Show a LoadingSpinner inside the submit button during submission - Add aria-busy to the form for screen reader accessibility - Update keyboard navigation to work with async submit handler - Add tests verifying button is disabled during in-flight requests and aria-busy attribute transitions correctly
|
@Eromosele0110 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Type of Change
Testing Done
Checklist
Related Issues
Closes #942