fix: E2E mocking, visual regression stability, bundle size budget, accessible loading fallback#1028
Merged
Merged
Conversation
…lug#950 solutions-plug#951 — E2E mocking, visual regression stability, bundle size budget, accessible loading fallback closes solutions-plug#948 closes solutions-plug#949 closes solutions-plug#950 closes solutions-plug#951 solutions-plug#948 — Split E2E into mocked (PR CI) and integration (merge to main) suites. Added playwright.config.ts project split with MOCKED_SPECS list; mocked specs use page.route() and need no live backend. New e2e-mocked CI job runs on every PR; real-backend tests remain in the staging workflow triggered on main merges. solutions-plug#949 — Added maxDiffPixelRatio: 0.01 to every toHaveScreenshot() call in visual-regression.spec.ts to absorb sub-pixel font rendering differences. Added frontend/e2e/docker/Dockerfile.visual-regression with pinned font packages (fonts-liberation, fonts-noto-core, fontconfig) for a fixed rendering environment. Updated e2e/README.md with Docker baseline update process. Added e2e-visual-regression CI job that runs tests inside the Docker image. solutions-plug#950 — Added @next/bundle-analyzer (15.3.4) and bundlewatch (2.3.3) dev dependencies. Wrapped nextConfig with withBundleAnalyzer in next.config.js (enabled via ANALYZE=true). Added bundlewatch.config.json with size budgets for vendor, main, and _app chunks. Added 'analyze' and 'bundlewatch' npm scripts. Added bundle-size CI job that builds the app and runs bundlewatch. Updated PR template with a bundle size table for reviewers. solutions-plug#951 — Replaced plain <div role='status' aria-live='polite'>Loading...</div> fallbacks in page.tsx with the existing LoadingSpinner component, which already carries role='status', aria-live='polite', and aria-label. Added frontend/src/app/__tests__/page.test.tsx verifying the fallback element has the correct ARIA attributes and no axe violations.
|
@joshuagit706 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
…utions-plug#950 solutions-plug#951 — E2E mocking, visual regression stability, bundle size budget, accessible loading fallback" This reverts commit 5314bef.
…lug#950 solutions-plug#951 — E2E mocking, visual regression stability, bundle size budget, accessible loading fallback closes solutions-plug#948 closes solutions-plug#949 closes solutions-plug#950 closes solutions-plug#951 solutions-plug#948 — Split E2E into mocked (PR CI) and integration (merge to main) suites. Added playwright.config.ts project split with MOCKED_SPECS list; mocked specs use page.route() and need no live backend. New e2e-mocked CI job runs on every PR; real-backend tests remain in the staging workflow triggered on main merges. solutions-plug#949 — Added maxDiffPixelRatio: 0.01 to every toHaveScreenshot() call in visual-regression.spec.ts to absorb sub-pixel font rendering differences. Added frontend/e2e/docker/Dockerfile.visual-regression with pinned font packages (fonts-liberation, fonts-noto-core, fontconfig) for a fixed rendering environment. Updated e2e/README.md with Docker baseline update process. Added e2e-visual-regression CI job that runs tests inside the Docker image. solutions-plug#950 — Added @next/bundle-analyzer (15.3.4) and bundlewatch (2.3.3) dev dependencies. Wrapped nextConfig with withBundleAnalyzer in next.config.js (enabled via ANALYZE=true). Added bundlewatch.config.json with size budgets for vendor, main, and _app chunks. Added 'analyze' and 'bundlewatch' npm scripts. Added bundle-size CI job that builds the app and runs bundlewatch. Updated PR template with a bundle size table for reviewers. solutions-plug#951 — Replaced plain <div role='status' aria-live='polite'>Loading...</div> fallbacks in page.tsx with the existing LoadingSpinner component, which already carries role='status', aria-live='polite', and aria-label. Added frontend/src/app/__tests__/page.test.tsx verifying the fallback element has the correct ARIA attributes and no axe violations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolves four open issues in a single PR: E2E backend mocking, visual regression environment stability, bundle size budget enforcement, and accessible loading fallback.
Type of Change
Testing Done
maxDiffPixelRatio: 0.01and a pinned Docker imageBundle Size
Checklist
Related Issues
closes #948
closes #949
closes #950
closes #951