fix(email): crash reporting, context limit, schema validation, cachin…#1026
Merged
hman38705 merged 1 commit intoJun 30, 2026
Merged
Conversation
…g bench Issue 1 - Crash reporting: - Add worker_crash_total IntCounterVec to Metrics - Wrap email worker spawn in monitored restart loop (max 5 restarts, exponential backoff 1s/2s/4s/8s/16s), log FATAL on exhaustion - Add EmailWorkerDown and EmailWorkerCrashLooping Prometheus alerts Issue 2 - Template caching: - Templates already compiled once at EmailTemplateEngine::new() startup - Add benches/email_templates.rs: cached vs per-request at 1000 renders - Register bench in Cargo.toml; document restart-to-update policy Issue 3 - Context size limit: - Reject contexts > 64 KB (serialised JSON) in render() before Handlebars - Return structured anyhow error with byte count and template name Issue 4 - Template schema validation: - Add templates/schema.json documenting required vars per template - validate_all_templates() uses realistic per-template fixture data - Add 16 boundary-value tests: empty strings, special chars, long strings, XSS escaping, and startup validation sanity check Misc: tighten .gitignore (test snapshots, bench output, temp files)
|
@judikay95 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
hman38705
added a commit
that referenced
this pull request
Jun 30, 2026
…lidation, caching Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…g bench
Issue 1 - Crash reporting:
Issue 2 - Template caching:
Issue 3 - Context size limit:
Issue 4 - Template schema validation:
Misc: tighten .gitignore (test snapshots, bench output, temp files)
Description
Type of Change
Testing Done
Checklist
Related Issues
Closes #
closes #928
closes #929
closes #930
closes #931