Conversation
…olidjs#3729) <textarea /> put the tokenizer in raw text mode because only the token before the last was checked for a slash, so the rest of the template was read as text. Check the last token as well; closing tags still have their slash second to last. Fixes solidjs#3729
🦋 Changeset detectedLatest commit: f0af93d The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merging this PR will not alter performance
Comparing 
Footnotes
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3729.
Summary
After a self-closing raw text element such as
<textarea />, the tokenizer stayed in raw text mode and treated the rest of the template as text. The self-closing check only looked two tokens back, so it missed the/directly before>. This also checks the previous token.How did you test this change?
Added tests in
packages/html/test/tokenize.test.tsandparse.test.ts; they fail before the fix.vitest run test/tokenize.test.ts test/parse.test.tsinpackages/html: 123 passed, 0 failed.Not run:
pnpm build, fullpnpm test, prettier.