chore: ride solid 2.0.0-rc.13 - #384
Merged
Merged
Conversation
Bump the solid-js / @solidjs/web peer floor and the @solidjs/compiler / @solidjs/babel-plugin dependency floors from ^2.0.0-rc.10 to ^2.0.0-rc.13 (the @solidjs/diagnostics dev pin and the examples' catalog follow). rc.13 is the first published release with the new server-component SSR marker contract (rc.12 was never published): `_s:on:*` / `_s:ref` attribute-slot markers replace `_bnd`, dynamic class/style compile to whole-attribute ssrElementAttribute holes, and spread elements hand ssrElement a trailing claims thunk. A <= rc.11 compiler paired with an rc.13 runtime emits markers the runtime no longer reads, so the floors move together. Rewrites the stale `_bnd` comment in getSolidOptions; no behavior change. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: 995727b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rides Solid 2.0.0-rc.13. The
solid-js/@solidjs/webpeer floor and the@solidjs/compiler/@solidjs/babel-plugindependency floors move from^2.0.0-rc.10to^2.0.0-rc.13(the@solidjs/diagnosticsdev pin and the examples'catalog:entries follow, as in #371); the build, the Cypress and Vitest suites and every example suite pass against it. No code change — a floor bump plus one stale comment.What
package.json— everysolid-js,@solidjs/web,@solidjs/compiler,@solidjs/babel-pluginrange (dependencies, devDependencies, peerDependencies)^2.0.0-rc.10→^2.0.0-rc.13; the exact@solidjs/diagnosticsdevDependency2.0.0-rc.10→2.0.0-rc.13.pnpm-workspace.yaml— thesolid-js/@solidjs/webcatalog the examples consume viacatalog:, and2.0.0-rc.13appended to the existingminimumReleaseAgeExcludeentries, mirroring feat: source names for the dev and observe postures #371.pnpm-lock.yaml— regenerated withpnpm install(pnpm 9.15.3); every Solid package resolves to rc.13,@solidjs/signalsincluded.src/index.ts— thegetSolidOptionscomment describing whatserverFunctions.componentsturns on still named the_bndbehavior-claim marker; rewritten for the rc.13 contract (below). Comment only, no behavior change..changeset/solid-rc13.md—patch(pre mode).Why
The plugin rides a Solid rc in lockstep. With
^2.0.0-rc.10, an existing lockfile can hold@solidjs/compiler/@solidjs/babel-pluginat ≤ rc.11 while the app moves its runtime to rc.13, and rc.13 is the first published release where that pairing is wrong forserverFunctions.componentsapps (rc.12 was never published):ssrClaimhole per element, but the runtime now emits_s:on:<event>/_s:refattribute-slot markers in place of the_bndbehavior-claim marker, which the rc.13 client no longer reads. A dynamicclass/styleunderserverComponentscompiles to a whole-attributessrElementAttributehole so a client attribute slot can own it, and a spread element's namedref/on*are handed tossrElementas a seventhclaimsargument (previously they dropped silently).$keyon spread elements.A ≤ rc.11 compiler paired with an rc.13 runtime therefore emits markup the runtime does not resolve. Pinning the floor to rc.13 keeps compiler ↔ runtime in lockstep. An audit of what the plugin couples to (export maps, compiler option surface,
_SOLID_*constants, the server-function contract, the dedupe set) found nothing else changed between rc.11 and rc.13, so no plugin code needs to follow.Verification
npm view … versions:solid-js,@solidjs/web,@solidjs/signals,@solidjs/compiler,@solidjs/babel-plugin,@solidjs/diagnosticsall publish2.0.0-rc.13(and no rc.12).pnpm install→node_modules/solid-js,@solidjs/web,@solidjs/compiler,@solidjs/babel-plugin,@solidjs/diagnosticsat2.0.0-rc.13; the installed@solidjs/webserver build carries the_s:on/_s:refmarkers and no_bnd.pnpm build— rollup +tsc --emitDeclarationOnlypass.pnpm test(Cypress e2e,vite-8) — 1 spec, 1 test passing, 0 failing.examples/vite-8:pnpm test(Vitest browser mode, Chromium) — 1 file, 1 test passing.pnpm testin each):ssr12/12 + boundary 8/8;css-matrix87/87 + bridge 19/19;start-client65/65;start-env47/47;start-ssr— the fullrun.mjspass came in at 576/579 with three headless-Chrome timing failures (frames-prod/bootadoption read before the panel landed, andnode/run"Chrome CDP not reachable" from a stale/tmp/start-ssr-chrome-nodeprofile); both modes pass in isolation (frames61/61,node74/74), and the companion scripts pass: http-bridge 10/10, components-warning 11/11, webworker-warning 12/12, dedupe 8/8.src/index.tsandpnpm-workspace.yamlalready had unrelated pre-existing prettier drift onnext(lines 109 / 1063 ofindex.ts), left alone so this diff stays a floor bump.Public API changes
peerDependencies.solid-jsandpeerDependencies.@solidjs/webmove from^2.0.0-rc.10to^2.0.0-rc.13. Consumers on rc.10 / rc.11 get a peer warning from their package manager and must upgrade their runtime to rc.13 to use this plugin release.dependencies.@solidjs/compileranddependencies.@solidjs/babel-pluginmove to^2.0.0-rc.13, so an install of this plugin release always brings the rc.13 compilers (a^2.0.0-rc.10lockfile can no longer hold a ≤ rc.11 compiler).— Claude via Cursor