Highlight error sources with twinkleplop, update to Solid rc.9 - #20
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Replace shiki with twinkleplop. The highlighter runs synchronously, so a stack frame's source appears with the panel instead of a moment later, and the package no longer carries a WebAssembly grammar engine: the build drops from 8.1 MB to 3.6 MB. The error line and the word the frame points at are marked with the `hl` and `err` directives, written as comments on their own lines above the snippet. The code is never edited to carry a marker, and a line holding only a marker is dropped from the output. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The code view cut the file down to the window it shows before highlighting it. A window that starts inside a block comment or a template literal left the highlighter reading an opening it never saw, and every line after that read as comment. The whole file is highlighted now, and the lines outside the window are hidden through render overlays instead of cut away. The frame's line is marked with the `focus` directive, so the lines around it can step back. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The view showed fifteen lines on each side of the frame, while its scrollbar reaches about twenty-five, so the reader could scroll into lines that were not there. It now keeps far more of the file than the scrollbar can reach and opens on the frame's line. The bound is only there to stop a very large file from putting every one of its lines in the page. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The code view keeps a window that matches how far it scrolls, so the reader never scrolls into lines that are missing and the panel never holds a whole file. The window is cut after highlighting, not before, so a block comment or template literal above it still reads correctly. Lines outside it are tagged through the renderer's line hook and dropped from the markup, which the hide overlays did not do at the offsets they were given. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`.changeset/rc12-runtime-parity.md` described the rc.12 runtime, but rc.12 was never published; `package.json` pins and peers `^2.0.0-rc.13`, so the changelog line now says rc.13. Also carries the rebase fix-ups for #20: the `@twinkleplop/*` ranges move to the patches the regenerated lockfile resolved and the suite was verified against (`annotation`/`tsx`/`typescript` 0.1.5, `theme-github` 0.2.2). Co-authored-by: Cursor <cursoragent@cursor.com>
5ddbecc to
3f47c8e
Compare
|
focusdirective and the word it points at witherr.@solidjs/compilerin place of@dom-expressions/compiler.🤖 Generated with Claude Code