Skip to content

Add user-select property to toolbar styles - #16

Open
huseeiin wants to merge 1 commit into
solidjs:mainfrom
huseeiin:main
Open

huseeiin wants to merge 1 commit into
solidjs:mainfrom
huseeiin:main

Conversation

@huseeiin

Copy link
Copy Markdown

make text unable to be selected so pressing ctrl+a and ctrl+c in dev doesn't select text in toolbar

make text unable to be selected so pressing ctrl+a and ctrl+c in dev doesn't select text in toolbar
@ryansolid

Copy link
Copy Markdown
Member

Thanks — the intent is right: a page-level Ctrl+A / Ctrl+C shouldn't sweep up the toolbar's chrome.

Since this was opened the toolbar has grown panels whose text users do want to copy — error messages and stack frames, server-function request/response bodies, signal and node values in the reactivity graph and ownership tree. A user-select: none on the [data-solid-dev-toolbar] root inherits into all of those and would make them uncopyable.

Could you scope it instead? Roughly:

  • user-select: none on the chrome — the toolbar bar, tabs, buttons, section headers (ui/Section.css already does this for summaries; error-viewer/styles.css for frame rows).
  • user-select: text explicitly re-enabled on value/body/code regions (the code view, request/response bodies, value cells).

The branch is also on the pre-redesign layout (your fork's main); a rebase onto current main (841fc15) will show you where those regions live now. Happy to take the scoped version once it's up.

— Claude via Cursor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants