Skip to content

Pin Solid main c467fcd7f; repro for solidjs/solid#5146 - #90

Merged
ryansolid merged 1 commit into
mainfrom
claude/project-thread-xp2irv
Nov 21, 2026
Merged

ryansolid merged 1 commit into
mainfrom
claude/project-thread-xp2irv

Conversation

@ryansolid

Copy link
Copy Markdown
Member

What changes

  • ref/SOLID_NEXT moves to Solid main c467fcd7f. That brings the optimistic engine refactor (#5137), #5140, and the fix for #5097.
  • The #5097 fix makes a server projection over a pending store wait for it. As a side effect, the projection now hydrates as an answer of its own, and the hydrated client projection stops following its source. I filed that as [2.0 hydration] A projection over an async store, hydrated, stops following its source (follow-up to #5097) solid#5146, with a plain-Solid hydration repro in ref/oracle/repros/proj-hydrate.
  • Because of #5146, the server runtime still creates the guess layer (truth plus layer, AC-3) only to keep its owner slot, and renders the truth. The comment now points at #5146.

Tests

  • ref, oracle and compiled 135/135
  • ssr 128 (7 skip)
  • types 181
  • crate 372/372
  • The board reference and the three probe-6 apps grade the same as on 99db9bce4: reference 0/20 fuzz seeds, probe 6 at 2/2/1 raw, which is 1/0/1 once the ruled holds are excluded.

Generated by Claude Code

… repro for solidjs/solid#5146

#5097's fix (a server projection over a pending store waits for it) makes the projection hydrate as an answer of
its own, and the hydrated client projection then stops following its source (#5146, ref/oracle/repros/proj-hydrate).
So the server runtime keeps creating the guess layer for its owner slot only and rendering the truth.

ref, oracle and compiled 135/135, ssr 128 (7 skip), types 181, crate 372/372. Board reference and probe 6
grade as on 99db9bce4.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWLtkg281f1NkGEDjCt
@cloudflare-workers-and-pages

Copy link
Copy Markdown

🚀 Deploying Preview to Cloudflare 🚀

Preview Deployments by commit

Status Deployment URL Commit Updated (UTC) See this deployment's details
  • Build: Failed ❌

View logs ↗
f640448 2026-11-21T08:28:41.138Z View logs ↗

@ryansolid
ryansolid merged commit 33f862f into main Nov 21, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants