Normalize lazy-ref src values - #7
Merged
Merged
Conversation
brenelz
approved these changes
Sep 3, 2026
brenelz
reviewed
Sep 3, 2026
Turn the tests job into an os matrix (ubuntu-latest, windows-latest), fail-fast off. The posix-separator regression test is trivially green on Linux — it only fails on a Windows runner, where node:path relative() emits backslashes. Without Windows in CI the invariant is pinned but never enforced; this makes the regression impossible to reintroduce unnoticed.
node:path relative() emits Windows separators, which never match Vite's always-posix client-manifest keys — SSR hydration preloads miss and server lazy() breaks. Every other path in the pipeline is already normalized through normalizePath(); these two sites were the only ones missed. Turns the regression test from the previous commit green on Windows.
Mersho
force-pushed
the
fix/windows-backslash
branch
from
September 12, 2026 00:13
745ffdf to
89cb733
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6