Repository navigation
chore: dev dependency audit fixes and fixture test timeout - #264
Merged
Merged
Conversation
…meout - Refresh the lockfile within the existing ranges and bump lint-staged to ^16 (fixes the micromatch and yaml alerts). - Add pnpm overrides for dev-only transitive alerts: minimatch 9.x, vite, source-map-js and esbuild. - `pnpm audit` goes from 40 alerts (18 high) to 2 that have no patched release in range yet: minimatch <11.0.1 (moderate, via api-extractor and typescript-eslint) and picomatch <=4.0.7 (high, no fixed 4.x published). None of these are dependencies of the published packages. - Drop an eslint-disable comment the updated eslint-plugin-eslint-plugin reports as unused. - Give the integration tests in test/ a 30s timeout. They start ESLint and lint whole fixture trees; on CI they run next to the plugin's suite and have taken 2-5s since validate-jsx-nesting landed (#227), flaking on the 5s default (main run 42463563675). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWPBR5hjwWf2VYS9c3p
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Ryan · project thread
Dev-only housekeeping for the Dependabot alerts on
mainand the flaky fixture test.Audit
package.jsonrange changes), andlint-stagedbumped to^16(micromatch and yaml alerts).pnpm-workspace.yamloverrides for dev-only transitives: minimatch 9.x, vite, source-map-js and esbuild.pnpm auditgoes from 40 alerts (18 high) to 2 with no patched release in range: minimatch<11.0.1(moderate, via api-extractor and typescript-eslint, needs a major) and picomatch<=4.0.7(high, no fixed 4.x published yet).eslint-plugin-solidoreslint-solid-standalone.eslint-plugin-eslint-pluginreports oneeslint-disablecomment injsx-uses-vars.tsas unused, so it is removed.Flaky fixture test
The integration tests in
test/start ESLint (or oxlint) and lint whole fixture trees with every rule on. On CI they run while turbo runs the plugin's own suite, and sincevalidate-jsx-nestinglanded (#227) a fixture run has taken 2-5s there, over vitest's 5s default (it failed the push run onmainafter #256). They now get a 30s timeout. Nothing is skipped.Tests
PARSER=allturbo build/test/docs/lint/tsc pass.🤖 Generated with Claude Code
https://claude.ai/code/session_0117BoWPBR5hjwWf2VYS9c3p