Skip to content

chore: dev dependency audit fixes and fixture test timeout - #264

Merged
ryansolid merged 1 commit into
mainfrom
chore/dev-deps-audit
Nov 17, 2026
Merged

ryansolid merged 1 commit into
mainfrom
chore/dev-deps-audit

Conversation

@ryansolid

Copy link
Copy Markdown
Member

Requested by Ryan · project thread

Dev-only housekeeping for the Dependabot alerts on main and the flaky fixture test.

Audit

  • Lockfile refreshed within the existing ranges (no package.json range changes), and lint-staged bumped to ^16 (micromatch and yaml alerts).
  • pnpm-workspace.yaml overrides for dev-only transitives: minimatch 9.x, vite, source-map-js and esbuild.
  • pnpm audit goes from 40 alerts (18 high) to 2 with no patched release in range: minimatch <11.0.1 (moderate, via api-extractor and typescript-eslint, needs a major) and picomatch <=4.0.7 (high, no fixed 4.x published yet).
  • None of these are dependencies of the published eslint-plugin-solid or eslint-solid-standalone.
  • The updated eslint-plugin-eslint-plugin reports one eslint-disable comment in jsx-uses-vars.ts as unused, so it is removed.

Flaky fixture test

The integration tests in test/ start ESLint (or oxlint) and lint whole fixture trees with every rule on. On CI they run while turbo runs the plugin's own suite, and since validate-jsx-nesting landed (#227) a fixture run has taken 2-5s there, over vitest's 5s default (it failed the push run on main after #256). They now get a 30s timeout. Nothing is skipped.

Tests

PARSER=all turbo build/test/docs/lint/tsc pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_0117BoWPBR5hjwWf2VYS9c3p

…meout

- Refresh the lockfile within the existing ranges and bump lint-staged to
  ^16 (fixes the micromatch and yaml alerts).
- Add pnpm overrides for dev-only transitive alerts: minimatch 9.x, vite,
  source-map-js and esbuild.
- `pnpm audit` goes from 40 alerts (18 high) to 2 that have no patched
  release in range yet: minimatch <11.0.1 (moderate, via api-extractor and
  typescript-eslint) and picomatch <=4.0.7 (high, no fixed 4.x published).
  None of these are dependencies of the published packages.
- Drop an eslint-disable comment the updated eslint-plugin-eslint-plugin
  reports as unused.
- Give the integration tests in test/ a 30s timeout. They start ESLint and
  lint whole fixture trees; on CI they run next to the plugin's suite and
  have taken 2-5s since validate-jsx-nesting landed (#227), flaking on the
  5s default (main run 42463563675).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWPBR5hjwWf2VYS9c3p
@ryansolid ryansolid self-assigned this Nov 17, 2026
@ryansolid
ryansolid merged commit 620fb10 into main Nov 17, 2026
3 checks passed
@ryansolid
ryansolid deleted the chore/dev-deps-audit branch November 17, 2026 17:45
@ryansolid ryansolid mentioned this pull request Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant