chore(test): e2e test for test-tabs-bottom-accessory-visibility-ios - #4534
Draft
LKuchno wants to merge 4 commits into
Draft
chore(test): e2e test for test-tabs-bottom-accessory-visibility-ios#4534LKuchno wants to merge 4 commits into
LKuchno wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds iOS 26+ Detox coverage for TabsHost bottom accessory visibility and updates related test gating and documentation.
Changes:
- Added end-state tests for hidden and rendered accessory transitions.
- Gated bottom-accessory suites to iOS 26+.
- Added test IDs and updated coverage documentation.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
FabricExample/e2e/single-feature-tests/tabs/test-tabs-bottom-accessory-visibility-ios.e2e.ts |
Adds visibility E2E tests |
FabricExample/e2e/single-feature-tests/tabs/test-tabs-bottom-accessory-layout-ios.e2e.ts |
Applies iOS 26+ gating |
FabricExample/e2e/e2e-utils.ts |
Adds shared iOS 26 suite gates |
apps/src/tests/single-feature-tests/tabs/test-tabs-bottom-accessory-visibility-ios/scenario.md |
Documents E2E coverage |
apps/src/tests/single-feature-tests/tabs/test-tabs-bottom-accessory-visibility-ios/scenario-description.ts |
Marks coverage incomplete |
apps/src/tests/single-feature-tests/tabs/test-tabs-bottom-accessory-visibility-ios/index.tsx |
Adds Detox test IDs |
Suppressed comments (1)
FabricExample/e2e/e2e-utils.ts:44
- This description does not match the gate:
isIOSVersionAtLeast('26.0')skips every iOS version below 26, including iOS 19–25, not only iOS 18 and older. Please update the comment so the documented supported/skip range is accurate.
* Suites for iOS 26+-only features (e.g. `bottomAccessory`, the header overflow
* button). `isIOSVersionAtLeast` is false on Android, so these stay iOS-only
* and additionally self-skip on iOS 18 and older.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
LKuchno
marked this pull request as draft
August 21, 2026 08:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes: https://github.com/software-mansion/react-native-screens-labs/issues/1745
Adds Detox e2e coverage for the iOS
bottomAccessoryHiddenprop onTabsHost, covering the end state of each step of thetest-tabs-bottom-accessory-visibility-iosscenario on iPhone.Both
hidden(bottomAccessoryHidden) andrendered(bottomAccessoryset /undefined) remove the accessory from the native hierarchy, so presence is asserted the same way for both and cross-checked against the tab bar: the tab item pill (_UITabButton) spans the accessory's width while one is attached and shrinks back once it is gone (checked relatively, no hardcoded constants).bottomAccessoryonly exists on iOS 26+, so both bottom-accessory suites now run only there: a shareddescribeIfiOS26/describeIfiPadIOS26ine2e-utils(isIOSVersionAtLeast('26.0')) skips them on older iOS and on Android.Animation quality (smooth slide out/in, no blank frame) stays manual - Detox samples settled state, not animation frames.
Changes
FabricExample/e2e/single-feature-tests/tabs/test-tabs-bottom-accessory-visibility-ios.e2e.ts- oneitper scenario step: baseline,hiddenon/off,renderedoff/on, and the combinedhidden+renderedsequence.FabricExample/e2e/e2e-utils.ts: addeddescribeIfiOS26anddescribeIfiPadIOS26.test-tabs-bottom-accessory-layout-ios.e2e.ts: iPhone and@ipadsuites switched to the iOS 26+ gates.index.tsx: addedtestIDs only (bottom-accessory-visibility-scrollview,rendered-switch,hidden-switch,bottom-accessory-text).scenario.md:## E2E testsection states the coverage split;scenario-description.ts:e2eCoverage→'incomplete'.