Skip to content

cherry-pick(4.7-stable): bump the patch of a released version for nightly versions (#10937) - #10938

Merged
tjzel merged 1 commit into
4.7-stablefrom
@tjzel/4.7-stable/cherry-pick-#10937
Oct 21, 2026
Merged

tjzel merged 1 commit into
4.7-stablefrom
@tjzel/4.7-stable/cherry-pick-#10937

Conversation

@tjzel

@tjzel tjzel commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

Cherry-picking #10937

@coderabbitai

coderabbitai Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 22cf0e38-091e-42fb-8bda-4b855e38e655
📥 Commits

Reviewing files that changed from the base of the PR and between 2c8eef3 and 154b922.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
📝 Walkthrough

The release script now keeps the base version for prerelease inputs and increments the patch version for stable inputs before adding the nightly identifier, date, and commit hash. New fixtures and tests cover prerelease and stable inputs, released-version patch bumps, and stable-version preservation.

Priority: ⬇️ Low

Change: Bug fix

Merge Risk: 🔵 Low · up to 2c8ee

Nightly version generation can fail for package versions containing build metadata. This is a bounded edge case, but it should be fixed or explicitly accepted before merging.

Pre-merge checks: Passed 4
Check name Status Explanation
Title check Passed The title clearly describes the main change: bumping the patch version of released versions for nightly builds in the 4.7-stable branch.
Description check Passed The description identifies the change as a cherry-pick of issue #10937, which matches the pull request objective and changeset.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1


ℹ️ Review info
⚙️ Run configuration
  • Configuration used: Repository UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: c0883c6f-ba47-4945-b2d2-61fe755f8c44
📥 Commits

Reviewing files that changed from the base of the PR and between 5fd93c3 and 2c8eef3.

📒 Files selected for processing: 4
  • scripts/__tests__/__fixtures__/releasing/released/package.json
  • scripts/__tests__/__fixtures__/releasing/unreleased/package.json
  • scripts/__tests__/releasing.test.mts
  • scripts/releasing.js

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

Comment thread scripts/releasing.js
@tjzel
tjzel force-pushed the @tjzel/4.7-stable/cherry-pick-#10937 branch from 2c8eef3 to 154b922 Compare October 21, 2026 16:52
@tjzel
tjzel merged commit eacd004 into 4.7-stable Oct 21, 2026
25 checks passed
@tjzel
tjzel deleted the @tjzel/4.7-stable/cherry-pick-#10937 branch October 21, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants