Repository navigation
fix(Reanimated): call lazy initializer in the useSharedValue mock - #10919
Merged
Merged
Conversation
Contributor
|
Caution Review failedThe pull request is closed. Walkthrough
Priority: Change: Bug fix Pre-merge checks:
 |
| Check name | Status | Explanation |
|---|---|---|
| Title check |  |
The title clearly and concisely describes the main change: calling the lazy initializer in the Reanimated useSharedValue mock. |
| Description check | |
The description directly explains the mock bug, the fix, the added test, and the changelog update. |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
- Configuration used: Repository UI
- Review profile: CHILL
- Plan: Advanced
- Run ID:
b41b1a04-abea-43a7-aa68-452dc38adcb9
📒 Files selected for processing: 3
packages/react-native-reanimated/__tests__/mock.useSharedValue.test.tsxpackages/react-native-reanimated/changelog/mock-shared-value-lazy-init.fix.mdpackages/react-native-reanimated/src/mock.ts
Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.
tjzel
approved these changes
Oct 26, 2026
tjzel
added a commit
that referenced
this pull request
Oct 26, 2026
…Value mock (#10920) > [!NOTE] > This pull request was authored by AI on behalf of @pawicao. ## Summary Stacked on #10919. The real `useSharedValue` keeps one shared value for the lifetime of the component. The Jest mock created a new object on every call, so the shared value changed identity on every render. Code that used it as a `useEffect` or `useMemo` dependency ran again on every render under the mock. I moved the mock shared value creation into the `useState` initializer, so each component keeps one shared value. ## Test plan I added a test to `__tests__/mock.useSharedValue.test.tsx` that re-renders the hook and compares the results. Before the fix it failed, after the fix it passes. The full reanimated Jest suite passes. ## Changelog - [x] I added a changelog fragment with `yarn changelog:add` for each changed package, or this PR does not change `react-native-reanimated` or `react-native-worklets`. Co-authored-by: Tomasz Żelawski <tzelawski@gmail.com>
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This pull request was authored by AI on behalf of @pawicao.
Summary
The real
useSharedValueaccepts a function as the initial value and calls it once on mount since 4.4.0. The Jest mock did not call the function. It stored the function as the value, souseSharedValue(() => 5).get()returned the function. I changed the mock to call the initializer wheninitis a function.Test plan
I added
__tests__/mock.useSharedValue.test.tsx. Before the fix it failed withExpected: 5, Received: [Function anonymous]. After the fix it passes.Changelog
yarn changelog:addfor each changed package, or this PR does not changereact-native-reanimatedorreact-native-worklets.