Repository navigation
fix(CSS): guard the processConfig trailing assert with NDEBUG - #10918
YogendraShelke wants to merge 1 commit into
Conversation
|
Important Review skippedReview was skipped as selected files did not have any reviewable changes.
|
matchedValues is only declared and incremented inside #ifndef NDEBUG blocks, but the assert reading it right after the loop was not wrapped the same way. Wrap it to match the existing guard pattern used twice earlier in the same function.
5b332cf to
e0060dd
Compare
Summary
In
CSSPlatformTransitionProxy::processConfig,matchedValuesis declared and incremented only inside two#ifndef NDEBUGblocks:but the assert reading it right after the loop was not wrapped the same way:
react_native_assert( matchedValues == config.changedProperties.size() && "[Reanimated] CSS transition value diff without settings");This is inconsistent with the guard pattern already used twice earlier in the same function. This PR wraps the assert in the same
#ifndef NDEBUGguard for consistency.Test plan
Mechanical, one-line change matching an existing pattern in the same function — no behavior change in debug builds (the assert still runs); in builds where
NDEBUGis defined,matchedValuesis no longer referenced outside its declaration.🤖 Generated with Claude Code