[RNE Rewrite] fix(build): remove redundant flag to fix macro redefinition warning - #1338
Merged
Conversation
…fix macro redefinition warning
msluszniak
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a -Wmacro-redefined compiler warning emitted when building native C++ sources. Build configurations (podspec, CMakeLists.txt, and compile_flags.txt) were explicitly setting the compiler definition
-DC10_USING_CUSTOM_GENERATED_MACROS=1. However, the vendored header Macros.h (third-party/include/torch/headeronly/macros/Macros.h) already defines#define C10_USING_CUSTOM_GENERATED_MACROSdirectly on line 1. Passing the preprocessor macro via compiler flags resulted in macro redefinition warning.Introduces a breaking change?
Type of change
Tested on
Testing instructions
Screenshots
Related issues
Checklist
Additional notes