[RNE Rewrite] docs(cpp): add missing C++ documentation in header files - #1337
Open
barhanc wants to merge 1 commit into
Open
[RNE Rewrite] docs(cpp): add missing C++ documentation in header files#1337barhanc wants to merge 1 commit into
barhanc wants to merge 1 commit into
Conversation
msluszniak
reviewed
Jul 30, 2026
Member
There was a problem hiding this comment.
Now when I read the names of the functions I'm wondering why we have such name convention. Str -> parseDtype, but reverse is named toString. For the next two the convention is unified, but we only know that we convert sth to scalar and we get sth from scalar. Maybe we should name it xFromY and xToY for both conversions? Especially, because we have dtypeToCvDepth and similar.
Member
Author
There was a problem hiding this comment.
Yeah, you are right. Let's wait with this PR until #1327 lands so we can change the names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds missing Doxygen documentation across C++ header files in
packages/react-native-executorch/cpp/.Introduces a breaking change?
Type of change
Tested on
Testing instructions
N/A
Screenshots
Related issues
Checklist
Additional notes