Skip to content

[RNE Rewrite] docs(cpp): add missing C++ documentation in header files - #1337

Open
barhanc wants to merge 1 commit into
rne-rewritefrom
@bh/add-cpp-docs
Open

[RNE Rewrite] docs(cpp): add missing C++ documentation in header files#1337
barhanc wants to merge 1 commit into
rne-rewritefrom
@bh/add-cpp-docs

Conversation

@barhanc

@barhanc barhanc commented Jul 30, 2026

Copy link
Copy Markdown
Member

Description

Adds missing Doxygen documentation across C++ header files in packages/react-native-executorch/cpp/.

Introduces a breaking change?

  • Yes
  • No

Type of change

  • Bug fix (change which fixes an issue)
  • New feature (change which adds functionality)
  • Documentation update (improves or adds clarity to existing documentation)
  • Other (chores, tests, code style improvements etc.)

Tested on

  • iOS
  • Android

Testing instructions

N/A

Screenshots

Related issues

Checklist

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly
  • My changes generate no new warnings

Additional notes

@barhanc barhanc self-assigned this Jul 30, 2026
@barhanc barhanc added the documentation Improvements or additions to documentation label Jul 30, 2026

@msluszniak msluszniak Jul 30, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now when I read the names of the functions I'm wondering why we have such name convention. Str -> parseDtype, but reverse is named toString. For the next two the convention is unified, but we only know that we convert sth to scalar and we get sth from scalar. Maybe we should name it xFromY and xToY for both conversions? Especially, because we have dtypeToCvDepth and similar.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, you are right. Let's wait with this PR until #1327 lands so we can change the names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants